This repository was archived by the owner on Feb 22, 2022. It is now read-only.
[stable/sonarqube] support imagePullSecret for private repositories#6845
Merged
k8s-ci-robot merged 1 commit intohelm:masterfrom Jul 26, 2018
Merged
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
william-tran
changed the title
william-tran
force-pushed
the
sonarqube-imagepullsecret
branch
from
9679066 to
fb013bb
Compare
Collaborator
Author
|
/retest |
Collaborator
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjkernick, william-tran The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Collaborator
Author
|
Thanks @rjkernick, that was fast! I wish I had that kind of turn around time on stable/concourse PRs. |
aba182
pushed a commit
to aba182/charts
that referenced
this pull request
Sep 7, 2018
Signed-off-by: aba182 <ajwilhel@gmail.com>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
gsemet
pushed a commit
to gsemet/charts
that referenced
this pull request
Nov 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add the ability to set an imagePullSecret to use in case you want to override the
image.repositoryand use a private one instead.