Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Vault: Adding ability to open cluster ip in k8s service#8054

Merged
k8s-ci-robot merged 6 commits intohelm:masterfrom
CharlieC3:vault-cluster-ip
Feb 14, 2019
Merged

Vault: Adding ability to open cluster ip in k8s service#8054
k8s-ci-robot merged 6 commits intohelm:masterfrom
CharlieC3:vault-cluster-ip

Conversation

@CharlieC3
Copy link
Copy Markdown
Contributor

@CharlieC3 CharlieC3 commented Sep 28, 2018

What this PR does / why we need it:

This PR adds a couple new values and updates the k8s Vault service to open up the cluster IP for high availability communication.

More specifically, this PR helps resolve this error in Vault logs:

2018-09-28T13:35:59.370Z [ERROR] core: handleRequestForwarding: error forwarding request: error="error during forwarding RPC request"
2018-09-28T13:44:10.912Z [ERROR] core: error during forwarded RPC request: error="rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = "transport: Error while dialing dial tcp 172.20.142.28:8201: i/o timeout""

Which issue this PR fixes

None

@CharlieC3
Vault: Adding ability to open cluster ip in k8s service
45741b3 
Signed-off-by: Charles Cantoni <charles.cantoni@gmail.com>
@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 28, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 28, 2018
@CharlieC3
Copy link
Copy Markdown
Contributor Author

CharlieC3 commented Oct 10, 2018

@linki @viglesiasce
Any updates on reviewing this PR? I'd like to have this merged in soon if possible. Thanks!

@CharlieC3
Copy link
Copy Markdown
Contributor Author

CharlieC3 commented Oct 22, 2018 •
edited
Loading

@linki
@viglesiasce
Are there any issues with this pr you'd like addressed?

@viglesiasce
Copy link
Copy Markdown
Contributor

viglesiasce commented Oct 23, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 23, 2018
viglesiasce
viglesiasce suggested changes Oct 23, 2018
View reviewed changes
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Nov 9, 2018
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Nov 9, 2018
Adding conditional block around exposing the cluster port
9d18358 
Signed-off-by: ccantoni <ccantoni@secureauth.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 9, 2018
Bumping chart version
26de5cc 
Signed-off-by: ccantoni <ccantoni@secureauth.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 9, 2018
@helm-bot helm-bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 9, 2018
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 9, 2018
@CharlieC3
Copy link
Copy Markdown
Contributor Author

CharlieC3 commented Nov 9, 2018

@viglesiasce I've addressed your concerns above, let me know if there's anything else!

@stale
Copy link
Copy Markdown

stale bot commented Dec 9, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 9, 2018
@stale
Copy link
Copy Markdown

stale bot commented Dec 23, 2018

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Dec 23, 2018
@CharlieC3
Copy link
Copy Markdown
Contributor Author

CharlieC3 commented Feb 8, 2019

@linki
@viglesiasce
Can this PR be reopened? This issue is still appearing in Vault deployments using this chart and it's a major issue.

See references below:
hashicorp/vault#3885
https://stackoverflow.com/questions/48321559/http-handlerequestforwarding-error-forwarding-request-error-error-during-forwa

@CharlieC3
Copy link
Copy Markdown
Contributor Author

CharlieC3 commented Feb 14, 2019

@linki
@viglesiasce
Please comment

@viglesiasce viglesiasce reopened this Feb 14, 2019
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2019
@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2019
@viglesiasce
Copy link
Copy Markdown
Contributor

viglesiasce commented Feb 14, 2019

/ok-to-test

Merge branch 'master' into vault-cluster-ip
c0c7ca1 
Signed-off-by: Vic Iglesias <viglesias@google.com>
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2019
@viglesiasce
Copy link
Copy Markdown
Contributor

viglesiasce commented Feb 14, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Feb 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlieC3, viglesiasce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit fbeb5f8 into helm:master Feb 14, 2019
@CharlieC3
Copy link
Copy Markdown
Contributor Author

CharlieC3 commented Feb 14, 2019

Thanks @viglesiasce !

@CharlieC3 CharlieC3 deleted the vault-cluster-ip branch February 14, 2019 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@linki linki Awaiting requested review from linki

1 more reviewer

@viglesiasce viglesiasce viglesiasce approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CharlieC3 @viglesiasce @k8s-ci-robot @ey-bot @helm-bot