upgrade.RunWithContext fails if task is canceled through context, rather than proceeding in the background

[rni-HMC]

Output of helm version: (from go.mod) helm.sh/helm/v3 v3.13.3

Output of kubectl version: (from go.mod) k8s.io/cli-runtime v0.29.0

Cloud Provider/Platform (AKS, GKE, Minikube etc.): Minikube

Using the helm go sdk, calling install.RunWithContext
with a context and then cancelling it, the install proceeds in the background, as documented.

However, calling upgrade.RunWithContext with a context and then cancelling it, the upgrade will proceed in the background, but warn "warning: Upgrade "my-test-deployment" failed: context canceled "

The output of helm status my-test-deployment --debug -n hmd-orc is:

NAME: my-test-deployment
LAST DEPLOYED: Wed Mar 13 17:53:15 2024
NAMESPACE: hmd-orc
STATUS: failed
REVISION: 3
TEST SUITE: None

However, the k8s pod, deployment, replicaset, all seem healthy, and everything appears to function correctly after the update. Only the helm release status shows as failed.

[dayeguilaiye]

This seems not a bug to me, maybe the request of updating resources already been sent to k8s, so the pod become healthy after cancel helm RunWithContext is reasonable.

The canceled context will stop wait of helm, so helm cannot assume the upgrade is success or failed. It can only return the context canceled error.

[rni-HMC]

It seems like a bug because the install.RunWithContext can succeed when the context is canceled. But upgrade.RunWithContext always fails. In the docs, "When the task is cancelled through ctx, the function returns and the install proceeds in the background."

[saisrikark]

Although the docs say this, I believe an error is returned with install.RunWithContext as well.
As it should be.

https://github.com/helm/helm/blob/release-3.15/pkg/action/install.go#L415

[github-actions]

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

[txli299]

Can we reopen this issue, it still happens that upgrade.RunWithContext fails in context canceled. We should expect the function to return and operation to proceed in the background even if task is cancelled through ctx, is that right?

[github-actions]

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.