Readiness & liveness probes correct port#11462
Merged
Conversation
Port number now comes from values.yaml Signed-off-by: Peter Leong <1179301+p33t@users.noreply.github.com>
pull-request-size
bot
added
the
size/XS
joejulian
approved these changes
Oct 21, 2022
Contributor
joejulian
left a comment
joejulian
left a comment
There was a problem hiding this comment.
Nice catch. I approve, though I'm not a core maintainer. This needs a review from one of them before it can be merged.
cndoit18
approved these changes
Oct 23, 2022
hickeyma
approved these changes
Oct 24, 2022
hickeyma
added
the
needs-pick
mattfarina
added
picked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port number now comes from values.yaml
closes #11461
What this PR does / why we need it: Fixes port number in generated
deployment.yaml(duringhelm create ...)Special notes for your reviewer: This works but might not be the right approach
If applicable: