Revert "fix(main): fix basic auth for helm pull or push"#12527
Merged
mattfarina merged 1 commit intohelm:mainfrom Oct 26, 2023
Merged
Revert "fix(main): fix basic auth for helm pull or push"#12527mattfarina merged 1 commit intohelm:mainfrom
mattfarina merged 1 commit intohelm:mainfrom
Conversation
pull-request-size
bot
added
the
size/M
This reverts commit 4a27baa. Note, PR helm#11129 was layered in along with this change so the revert preserves this API addition. Signed-off-by: Matt Farina <matt.farina@suse.com>
mattfarina
force-pushed
the
revert-12237
branch
from
8f2fb52 to
24e2864
Compare
sabre1041
approved these changes
Oct 26, 2023
Contributor
sabre1041
left a comment
sabre1041
left a comment
There was a problem hiding this comment.
LGTM
Tested against bearer and basic auth flows
mattfarina
added
needs-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4a27baa.
The change to improve basic auth support caused a regression for bearer tokens. Reverting the change until we have a well understood path forward.
Note, #11129 was layered in along with this and it has been preserved with the reversion. It added to the API and we do not want to remove that.
Closes #12491
What this PR does / why we need it:
Special notes for your reviewer:
Note, this was created with
git revertrather than GitHub because it was not a clean revert due to other changes that have happened since then. The original PR being reverted is #12237.If applicable: