test(cli): make User-Agent REST config test hermetic#31907
Open
LarytheLord wants to merge 1 commit intohelm:mainfrom
Open
test(cli): make User-Agent REST config test hermetic#31907LarytheLord wants to merge 1 commit intohelm:mainfrom
LarytheLord wants to merge 1 commit intohelm:mainfrom
Conversation
pull-request-size
bot
added
the
size/S
Signed-off-by: LarytheLord <llawlietbagsum@gmail.com>
LarytheLord
force-pushed
the
fix/test-kubeconfig-isolation-31470
branch
from
e706b31 to
3629ef6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31470
Summary
TestUserAgentHeaderInK8sRESTClientConfigcurrently depends on the machine's kubeconfig state. If the host has an invalid~/.kube/config(or invalid current context), the test fails for reasons unrelated to what the test is validating.What changed
pkg/cli/environment_test.goto create a temporary minimal kubeconfig inside the test.KUBECONFIGto that temporary file before callingToRESTConfig().Result
The test now validates only what it is meant to validate (the User-Agent wiring), and no longer depends on host-specific Kubernetes environment.
Notes
I could not run local
go testin this environment because Go is not installed and Docker daemon is unavailable. CI should run the full test suite.