Skip waiting for paused deployments#5789
Merged
bacongobbler merged 1 commit intohelm:masterfrom Oct 1, 2019
Merged
Conversation
Signed-off-by: Per Hermansson <perher1@gmail.com>
helm-bot
added
the
size/S
Member
|
Hey @perher! Thanks for the bugfix. I've restarted the CI tests as it appears to be a flaky error. This looks like a good fix. If you have the time, would you mind porting this over to the |
3 tasks
bacongobbler
approved these changes
Oct 1, 2019
bacongobbler
added
Needs v3 backport
gjenkins8
removed
the
Needs v3 backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In my chart I have multiple Deployments for different micro-services in my application. Some of the services have upgrade dependencies or requires special logic to perform rolling upgrade. To facilitate this I set those deployments to be in
pausedstate before the chart is upgraded.When running helm upgrade with paused deployments and when using the
--waitflag, the upgrade processed is stalled forever (or until timeout) since Kubernetes will not perform rolling upgrade on paused deployments. I propose to have Tiller ignore paused deployments altogether when waiting for a upgrade to finish since these will otherwise block the upgrade process.