fix: propagate registry_port to container and containerd#160
Open
Bisman-Singh wants to merge 1 commit intohelm:mainfrom
Open
fix: propagate registry_port to container and containerd#160Bisman-Singh wants to merge 1 commit intohelm:mainfrom
Bisman-Singh wants to merge 1 commit intohelm:mainfrom
Conversation
Fixes helm#143 Signed-off-by: Bisman-Singh <bismanmadaan1@gmail.com>
Author
|
@cpanato could you review this when you have a moment? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a non-default
registry_port(e.g. 5555), the registry container still listened on port 5000 internally. The Docker port mapping (5555:5000) only worked from the host but not from within the Kind network, so pods could not pull images using the configured port.Root cause:
docker run -p ${registry_port}:5000mapped the host port but the container always bound to 5000hosts.tomlhad port 5000 hardcoded instead of using${registry_port}Fix:
REGISTRY_HTTP_ADDR=0.0.0.0:${registry_port}so the registry binds on the configured port-p ${registry_port}:${registry_port}${registry_port}inhosts.tomlinstead of hardcoded 5000Tested with:
kind-registry:5555Fixes #143