feat: adding ability for for charts to be pulled with plain HTTP#1672
feat: adding ability for for charts to be pulled with plain HTTP#1672yxxhero merged 9 commits intohelmfile:mainfrom
Conversation
ennekein
requested review from
itscaro,
mumoshu,
xiaomudk and
yxxhero
as code owners
|
@yxxhero I see the test stage has failed, but I do not see any failed test. Any idea what the issue could be? |
|
@ennekein oh. you can find the failed case by searching |
|
@ennekein sorry. update the search keyword |
|
@yxxhero it gives me no result. However, I ran the tests in my VS Code and saw that |
|
@ennekein yeah. you should update. |
|
@ennekein oh. BTW. please fix DCO. follow this link: https://github.com/helmfile/helmfile/pull/1672/checks?check_run_id=28971568114 |
pkg/state/state.go
Outdated
|
|
||
| if release.PlainHttp || st.HelmDefaults.PlainHttp || repoPlainHttp { | ||
| flags = append(flags, "--plain-http") | ||
| } else if release.InsecureSkipTLSVerify || st.HelmDefaults.InsecureSkipTLSVerify || repoSkipTLSVerify { |
There was a problem hiding this comment.
please don't use else if? maybe we can return directly?
ennekein
force-pushed
the
main
branch
3 times, most recently
from
776c5d6 to
6accb8b
Compare
accomplished by: - Adding PlainHttp attribute to RepositorySpec., HelmDefault, ReleaseSpec - Adding UnitTests for getOCIChart Flags. - Adding funciton and unitTests for getChartDownload - Changing and refactoring how Flags are added to getOCIChart. Resolves helmfile#1224 Signed-off-by: Peter Halliday <peter.halliday@servicenow.com>
Signed-off-by: Pascal Rivard <privard@rbbn.com>
Signed-off-by: Pascal Rivard <privard@rbbn.com>
Signed-off-by: Pascal Rivard <privard@rbbn.com>
Signed-off-by: Pascal Rivard <privard@rbbn.com>
Signed-off-by: Pascal Rivard <privard@rbbn.com>
Signed-off-by: Pascal Rivard <privard@rbbn.com>
|
@ennekein LGTM. did you test it locally? |
|
@yxxhero I did build it locally and tested it with both HTTP and HTTPS registries. |
4 participants
accomplished by:
--plain-httpto helm commandsTweaked #1228 by @hoangelos
Resolves #1224