chore(ghost): bump ghost to 6.50.0#712
Conversation
github-actions
Bot
added
area:docs
area:schema
area:templates
area:tests
area:values
chart:ghost
Standards Check (GR-079) — PASSEvery changed chart fully passes standards-check. |
📝 WalkthroughWalkthroughThis PR bumps the Ghost chart to 6.50.0 across chart metadata, defaults, docs, and tests. It also adds a render-time ChangesGhost chart update
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Helm
participant ValidateTemplate as templates/validate.yaml
participant ValidateHelper as ghost.validate
Helm->>ValidateTemplate: render chart
ValidateTemplate->>ValidateHelper: include ghost.validate
ValidateHelper->>ValidateHelper: check database, ingress, gateway, externalSecrets
ValidateHelper-->>Helm: fail when required values are missing
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🟢 Security Scan:
|
| Framework | Score |
|---|---|
| MITRE + NSA + SOC2 | 89.393936% |
✅ Security posture acceptable.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
charts/ghost/templates/_helpers.tpl (1)
46-78: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd unittest coverage for the new
ghost.validatefailure branches.This helper enforces several hard render-time gates (database, ingress, gateway, externalSecrets). None of the provided files add a corresponding
helm-unittesttest asserting thesefailconditions trigger/don't trigger as expected. Given this directly blockshelm install/helm template, tests would help catch regressions when values defaults change.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@charts/ghost/templates/_helpers.tpl` around lines 46 - 78, Add helm-unittest coverage for the new failure paths in ghost.validate by creating tests that render the chart with invalid values and assert each fail branch is triggered, plus a few happy-path cases to confirm valid combinations pass. Focus the tests around the ghost.validate helper and the related gates for mysql/database.external.host, database.external.password or database.external.existingSecret, ingress.enabled/ingress.hosts, gateway.enabled/gateway.parentRefs, and externalSecrets.enabled with database.external.existingSecret, externalSecrets.secretStoreRef.name, and externalSecrets.data.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@charts/ghost/templates/_helpers.tpl`:
- Around line 46-78: Add helm-unittest coverage for the new failure paths in
ghost.validate by creating tests that render the chart with invalid values and
assert each fail branch is triggered, plus a few happy-path cases to confirm
valid combinations pass. Focus the tests around the ghost.validate helper and
the related gates for mysql/database.external.host, database.external.password
or database.external.existingSecret, ingress.enabled/ingress.hosts,
gateway.enabled/gateway.parentRefs, and externalSecrets.enabled with
database.external.existingSecret, externalSecrets.secretStoreRef.name, and
externalSecrets.data.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ec050b1a-e075-4781-88b1-8eb5168f9757
📒 Files selected for processing (7)
charts/ghost/Chart.yamlcharts/ghost/README.mdcharts/ghost/templates/_helpers.tplcharts/ghost/templates/validate.yamlcharts/ghost/tests/deployment_test.yamlcharts/ghost/values.schema.jsoncharts/ghost/values.yaml
|
Handled the CodeRabbit top-level nitpick in 4a8c71a. Added Validation:
This CodeRabbit item was posted only in the review summary, so there is no resolvable review thread to close. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
charts/ghost/tests/validation_test.yaml (1)
1-132: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAdd backup validation coverage.
ghost.validatealso callsghost.backupEnabled, but this suite doesn’t exercise thebackup.enabledfailure paths or a passing backup config. Add cases for missingbackup.s3.endpoint,backup.s3.bucket, andbackup.s3.accessKey/backup.s3.existingSecret.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@charts/ghost/tests/validation_test.yaml` around lines 1 - 132, Add validation coverage for the backup-related checks in the Validation suite so `ghost.validate` exercises `ghost.backupEnabled` as well. Extend the existing tests with failure cases for `backup.enabled` when `backup.s3.endpoint`, `backup.s3.bucket`, or both `backup.s3.accessKey`/`backup.s3.existingSecret` are missing, and add at least one passing case with a complete backup S3 configuration. Use the existing `ghost.validate` and `ghost.backupEnabled` paths as the reference points for where the validation behavior should be covered.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@charts/ghost/tests/validation_test.yaml`:
- Around line 1-132: Add validation coverage for the backup-related checks in
the Validation suite so `ghost.validate` exercises `ghost.backupEnabled` as
well. Extend the existing tests with failure cases for `backup.enabled` when
`backup.s3.endpoint`, `backup.s3.bucket`, or both
`backup.s3.accessKey`/`backup.s3.existingSecret` are missing, and add at least
one passing case with a complete backup S3 configuration. Use the existing
`ghost.validate` and `ghost.backupEnabled` paths as the reference points for
where the validation behavior should be covered.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 999f35c0-b3f9-442c-8146-09dbe875f18d
📒 Files selected for processing (1)
charts/ghost/tests/validation_test.yaml
1 participant
Closes #693.
Summary
Upstream Evidence
docker.io/library/ghost:6.50.0linux/amd64,linux/arm,linux/arm64,linux/s390x.Site Sync
Validation
make image-verify IMAGE=docker.io/library/ghost:6.50.0make deps-check CHART=ghosthelm unittest charts/ghostpassed: 6 suites, 23 tests.make validate-chart CHART=ghostpassed fully: 16 layers, including k3d behavioral validation for default and all CI values scenarios.make standards-check CHART=ghostnode scripts/charts/template-standards-check.js --chart ghostmake site-sync-check CHART=ghostmake release-check REPO=chartsmake attribution-check REPO=chartsSummary by CodeRabbit
New Features
Bug Fixes
Documentation