docs(ddns-updater): sync playground coverage#336
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis change adds the ChangesPlayground config allowlist update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
mberlofa
added a commit
to helmforgedev/charts
that referenced
this pull request
Jul 6, 2026
## Summary - align ddns-updater NOTES with the numbered HelmForge template standard - add centralized chart validation for ingress host requirements and reserved selector label overrides - preserve hostless ingress rendering for catch-all ingress rules and cover it with unittest coverage ## Validation - make template-standards-check CHART=ddns-updater - helm unittest charts/ddns-updater - helm lint --strict charts/ddns-updater - make standards-check CHART=ddns-updater - make validate-chart CHART=ddns-updater TIMEOUT=900: FULLY VALIDATED (14 layers) - make site-sync-check CHART=ddns-updater - make release-check REPO=charts - make attribution-check REPO=charts Site PR: helmforgedev/site#336 Issue: #633 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Updated Helm install notes into a structured, step-by-step guide with access instructions, expanded configuration details, security settings, and grouped resources/troubleshooting. * **Bug Fixes** * Improved ingress rendering to omit the host field when no host is provided, enabling clean hostless/catch-all rules. * **Bug Fixes / Validation** * Added Helm-time validation to fail fast when ingress hosts are missing and to block `podLabels` from overriding chart selector labels. * **Tests** * Added ingress and validation test coverage, including hostless behavior and expected validation failure messages. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: MergeCheck <mergecheck@example.invalid>
9ae2561 to
b19a411
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Chart PR: helmforgedev/charts#657
Issue: helmforgedev/charts#633
Summary by CodeRabbit
ddns-updaterchart in the playground, allowing it to appear in the available chart list when applicable.