Skip to content

Leaner CI matrix + test_io deadlock#2139

Merged
JuanPedroGHM merged 35 commits intomainfrom
2134-Prune_CI_matrix
Feb 24, 2026
Merged

Leaner CI matrix + test_io deadlock#2139
JuanPedroGHM merged 35 commits intomainfrom
2134-Prune_CI_matrix

Conversation

@ClaudiaComito
Copy link
Copy Markdown
Member

@ClaudiaComito ClaudiaComito commented Feb 21, 2026

Due Diligence

  • General:
  • Implementation:
    • unit tests: all split configurations tested
    • unit tests: multiple dtypes tested
    • NEW unit tests: MPS tested (1 MPI process, 1 GPU)
    • benchmarks: created for new functionality
    • benchmarks: performance improved or maintained
    • documentation updated where needed

Description

This PR implements a leaner CI matrix as discussed in #2134. The race condition + deadlock arising in test_io with Python 3.14 has also been solved.

Issue/s resolved: #2134

Changes proposed:

  • refactor ci.yaml as per Prune CI matrix #2134 . Runs for every commit as requested by @brownbaerchen
  • keep the full matrix in ci_full.yaml. This will run when a PR is merged into main, if the PR affects the codebase
  • in test_io.test_load_zarr_group prevent race condition by inserting a Barrier before starting to write out the zarr group. Might be related to PEP 703 in combination with Zarr V3's asynchronous I/O.

Type of change

  • Bug fix (non-breaking change which fixes an issue) + GH action refactoring

Memory requirements

DNA

Performance

DNA

Does this change modify the behaviour of other functions? If so, which?

no

@ClaudiaComito ClaudiaComito added this to the 1.7.1 milestone Feb 21, 2026
@ClaudiaComito ClaudiaComito moved this from Todo to In Progress in Roadmap Feb 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the PR!

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the PR!

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the PR!

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.63%. Comparing base (a6109ec) to head (583c941).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2139   +/-   ##
=======================================
  Coverage   91.63%   91.63%           
=======================================
  Files          89       89           
  Lines       14003    14003           
=======================================
  Hits        12832    12832           
  Misses       1171     1171           
Flag Coverage Δ
unit 91.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the PR!

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the PR!

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the PR!

brownbaerchen
brownbaerchen previously approved these changes Feb 23, 2026
@brownbaerchen
Copy link
Copy Markdown
Collaborator

Can anybody reproduce the deadlock locally? I can't with Python 3.14 and torch==2.9.1 torchvision==0.24.1 torchaudio==2.9.1.

Comment thread .github/workflows/ci_full.yaml
Comment thread .github/workflows/ci_full.yaml
Comment thread .github/workflows/ci.yaml
Comment thread .github/workflows/ci.yaml
@github-project-automation github-project-automation Bot moved this from Merge queue to In Progress in Roadmap Feb 24, 2026
@JuanPedroGHM
Copy link
Copy Markdown
Member

Can anybody reproduce the deadlock locally? I can't with Python 3.14 and torch==2.9.1 torchvision==0.24.1 torchaudio==2.9.1.

I could not reproduce it. Tried with torch==2.10.

@brownbaerchen
Copy link
Copy Markdown
Collaborator

@copilot, implement a time limit of 2 hours for the new lean CI and the full CI. Also, fix the deadlock in test_io. Do both by suggesting changes on this PR.

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 24, 2026

@brownbaerchen I've opened a new pull request, #2147, to work on those changes. Once the pull request is ready, I'll request review from you.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the PR!

Co-authored-by: brownbaerchen <39156931+brownbaerchen@users.noreply.github.com>
Add 2-hour timeout to CI jobs + fix test_io race condition
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the PR!

Copy link
Copy Markdown
Collaborator

@brownbaerchen brownbaerchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding pandas back in as optional dependency (needs #2149)

Comment thread .github/workflows/ci.yaml Outdated
Comment thread .github/workflows/ci.yaml Outdated
Comment thread .github/workflows/ci_full.yaml Outdated
Comment thread .github/workflows/ci_full.yaml Outdated
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the PR!

@JuanPedroGHM JuanPedroGHM dismissed their stale review February 24, 2026 16:41

Not relevant, addressed in pr #2149

@JuanPedroGHM JuanPedroGHM merged commit e9d34cc into main Feb 24, 2026
17 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Roadmap Feb 24, 2026
@brownbaerchen brownbaerchen deleted the 2134-Prune_CI_matrix branch February 25, 2026 08:58
This was referenced Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working workflows

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Prune CI matrix

4 participants