Leaner CI matrix + test_io deadlock#2139
Conversation
for more information, see https://pre-commit.ci
|
Thank you for the PR! |
|
Thank you for the PR! |
|
Thank you for the PR! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2139 +/- ##
=======================================
Coverage 91.63% 91.63%
=======================================
Files 89 89
Lines 14003 14003
=======================================
Hits 12832 12832
Misses 1171 1171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Thank you for the PR! |
1 similar comment
|
Thank you for the PR! |
for more information, see https://pre-commit.ci
|
Thank you for the PR! |
|
Can anybody reproduce the deadlock locally? I can't with Python 3.14 and torch==2.9.1 torchvision==0.24.1 torchaudio==2.9.1. |
I could not reproduce it. Tried with torch==2.10. |
|
@copilot, implement a time limit of 2 hours for the new lean CI and the full CI. Also, fix the deadlock in test_io. Do both by suggesting changes on this PR. |
|
@brownbaerchen I've opened a new pull request, #2147, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
Thank you for the PR! |
Co-authored-by: brownbaerchen <39156931+brownbaerchen@users.noreply.github.com>
Add 2-hour timeout to CI jobs + fix test_io race condition
|
Thank you for the PR! |
brownbaerchen
left a comment
There was a problem hiding this comment.
Adding pandas back in as optional dependency (needs #2149)
|
Thank you for the PR! |
Not relevant, addressed in pr #2149
Due Diligence
Description
This PR implements a leaner CI matrix as discussed in #2134. The race condition + deadlock arising in test_io with Python 3.14 has also been solved.
Issue/s resolved: #2134
Changes proposed:
ci.yamlas per Prune CI matrix #2134 . Runs for every commit as requested by @brownbaerchenci_full.yaml. This will run when a PR is merged intomain, if the PR affects the codebasetest_io.test_load_zarr_groupprevent race condition by inserting a Barrier before starting to write out the zarr group. Might be related to PEP 703 in combination with Zarr V3's asynchronous I/O.Type of change
Memory requirements
DNA
Performance
DNA
Does this change modify the behaviour of other functions? If so, which?
no