Skip to content

Next release #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baxyz merged 2 commits into from
Apr 25, 2026
+2 −2
Merged

Next release #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac6e892
fix(workflows): 🐛 correct parameter name for trigganator token action
baxyz Apr 24, 2026
f1e88a9
fix(CI-CD): 🐛 escape JSON in client-payload for proper parsing
baxyz Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
id: trigganator
uses: actions/create-github-app-token@v3
with:
app-id: ${{ vars.TRIGGANATOR_ID }}
client-id: ${{ vars.TRIGGANATOR_ID }}
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions/create-github-app-token@v3 expects the GitHub App identifier under the app-id input (paired with private-key). Using client-id here will be ignored by the action and will cause token generation (and the subsequent repository-dispatch) to fail. Switch this input back to app-id (or whichever exact input name the action documents) and keep the variable value the same.

Suggested change
client-id: ${{ vars.TRIGGANATOR_ID }}
app-id: ${{ vars.TRIGGANATOR_ID }}

Copilot uses AI. Check for mistakes.
private-key: ${{ secrets.TRIGGANATOR_KEY }}
owner: helpers4
repositories: website
Expand All @@ -57,4 +57,4 @@ jobs:
token: ${{ steps.trigganator.outputs.token }}
repository: helpers4/website
event-type: devcontainer-release
client-payload: '{"version": "${{ github.ref_name }}"}'
client-payload: "{\"version\": \"${{ github.ref_name }}\"}"
Copy link

Copilot AI Apr 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description is still the default template (no summary, type of change, testing details, or linked issue). Please update it so reviewers/release tooling have the necessary context for what "Next release" changes and how it was verified.

Copilot uses AI. Check for mistakes.
Loading