Skip to content

Fix harmony-temporal flag#47

Merged
baxyz merged 1 commit intomainfrom
for-alpha-17-bis
Apr 19, 2026
Merged

Fix harmony-temporal flag#47
baxyz merged 1 commit intomainfrom
for-alpha-17-bis

Conversation

@baxyz
Copy link
Copy Markdown
Contributor

@baxyz baxyz commented Apr 19, 2026

Description

Please include a summary of what this PR does and why it's needed.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring
  • Test improvement

Related Issues

Closes #(issue number)

How Has This Been Tested?

Describe the tests you ran and how to reproduce them:

  • Test A
  • Test B

Checklist

  • My code follows the code style of this project
  • I have updated the documentation accordingly
  • I have added tests for my changes
  • All new and existing tests passed locally
  • My commits follow the conventional commit format

Screenshots (if applicable)

Add screenshots for UI changes.

Additional Context

Add any other context about the PR here.

Copilot AI review requested due to automatic review settings April 19, 2026 20:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Vitest + Stryker configuration to avoid passing --harmony-temporal twice under Node.js 24, preventing ERR_WORKER_INVALID_EXEC_ARGV while keeping Temporal enabled for tests/mutation runs.

Changes:

  • Conditionally sets Vitest test.execArgv only when --harmony-temporal is not already present in process.execArgv.
  • Adds testRunnerNodeArgs: ['--harmony-temporal'] to Stryker so its spawned test-runner processes have Temporal enabled.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
vitest.config.ts Avoids duplicate --harmony-temporal in Vitest worker exec args by conditionally injecting execArgv.
stryker.config.mjs Ensures Stryker’s test-runner processes start with --harmony-temporal enabled on Node 24.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@baxyz baxyz merged commit 57b64ff into main Apr 19, 2026
19 checks passed
@baxyz baxyz deleted the for-alpha-17-bis branch April 19, 2026 20:31
@github-actions
Copy link
Copy Markdown
Contributor

✅ PR Validation Passed

All checks passed and coverage target reached!


📋 Pipeline Status

Job Status
🔢 Version passing
🏗️ Build passing
🧪 Tests passing
📝 Lint passing
📘 TypeCheck passing
🔐 Security Audit passing
🧾 Conventional Commits passing
🔗 Coherency passing

📊 Code Coverage

Overall Coverage: 100.0% — Target reached! 🎯

Metric Progress Coverage
Lines ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ 100%
Branches ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ 100%
Functions ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ 100%
Statements ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓ 100%

🧬 Mutation Testing

🟢 Mutation Score: 92.80% — excellent

Metric Progress Score
🟢 Mutation Score ▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░ 92.80%

🧬 Mutation testing is informational only and does not block the PR

📊 View full mutation report on Stryker Dashboard


🌐 Runtime Compatibility

Runtime Compatibility: 3/3 — All runtimes passed!

Runtime Status
🟩 Node.js 24 (LTS) v24.14.1
🦕 Deno 2.7.12
🍞 Bun 1.3.12

🔄 Runtime compatibility is informational only and does not block the PR


⏱️ Benchmarks

Benchmarks: 0 suites — completed

⏱️ Benchmarks are informational only and do not block the PR


ℹ️ About this report
  • 🎯 Coverage Target: 100% for all metrics
  • 🧬 Mutation Testing: powered by Stryker (non-blocking)
  • ⏱️ Benchmarks: powered by Vitest Bench (non-blocking)
  • 🔄 This comment updates automatically with each push
  • 📈 Coverage is measured using Vitest + v8

🤖 Generated by @helpers4 CI • 2026-04-19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants