Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Deploying helpers4 with
|
| Latest commit: |
6b09ba1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://89152b2d.helpers4.pages.dev |
| Branch Preview URL: | https://beta.helpers4.pages.dev |
✅ PR Validation Passed
📋 Pipeline Status
🤖 Generated by @helpers4 CI • 2026-04-23 |
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions release automation to generate docs on upstream releases and push the updated docs back to main, while removing the explicit Cloudflare Pages deploy step from CI.
Changes:
- Add GitHub App token generation and use it for authenticated checkout/push to
mainin release-triggered workflows. - Replace “build & deploy” steps in the release-triggered workflows with “commit and push updated docs”.
- Add new
on-*-release.ymlrepository_dispatch workflows and remove the Cloudflare deploy step fromdeploy.yml.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/typescript-release.yml |
Uses GitHub App token; generates TypeScript docs and commits/pushes them instead of deploying. |
.github/workflows/devcontainer-release.yml |
Uses GitHub App token; generates DevContainer docs and commits/pushes them instead of deploying. |
.github/workflows/action-release.yml |
Uses GitHub App token; generates Action docs and commits/pushes them instead of deploying. |
.github/workflows/on-typescript-release.yml |
New repository_dispatch workflow duplicating TypeScript release handling and pushing docs to main. |
.github/workflows/on-devcontainer-release.yml |
New repository_dispatch workflow duplicating DevContainer release handling and pushing docs to main. |
.github/workflows/on-action-release.yml |
New repository_dispatch workflow duplicating Action release handling and pushing docs to main. |
.github/workflows/deploy.yml |
Removes the Cloudflare Pages deploy step (workflow now builds/uploads artifacts only). |
Comments suppressed due to low confidence (2)
.github/workflows/deploy.yml:87
- The PR description is still the template and doesn’t explain a fairly impactful change (removing the Cloudflare Pages deploy step and switching release workflows to committing directly to
main). Please update the PR description with rationale and the expected deployment path after this change.
uses: actions/upload-artifact@v7
with:
name: dist
path: dist/
.github/workflows/deploy.yml:87
- This workflow is still named "Build and Deploy" but the Cloudflare Pages deploy step was removed; it now only uploads the
dist/artifact. If deployment is intentionally handled elsewhere (e.g., Cloudflare Git integration), consider renaming/adjusting the workflow to avoid confusion; otherwise reintroduce a deploy step so pushes tomainactually publish updates.
uses: actions/upload-artifact@v7
with:
name: dist
path: dist/
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/deploy.yml:87
- The Cloudflare Pages deployment step has been removed, so this workflow now only builds and uploads a
distartifact. If Cloudflare Pages is not configured to deploy via Git integration (or another downstream workflow), pushes tomainwill no longer publish the site. Consider re-adding a deploy step (e.g., wranglerpages deploy) or adding a separate deploy job that consumes the uploaded artifact.
- name: Build all packages
run: pnpm build:all
- name: Upload artifacts
uses: actions/upload-artifact@v7
with:
name: dist
path: dist/
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+49
to
+57
| if tar -tzf /tmp/build-meta.tar.gz | grep -Eq '(^/|(^|/)\.\.(/|$))'; then | ||
| echo "Unsafe path detected in build-meta.tar.gz" | ||
| exit 1 | ||
| fi | ||
| if tar -tvf /tmp/build-meta.tar.gz | awk '{print $1}' | grep -Eq '^[lh]'; then | ||
| echo "Symlink or hardlink detected in build-meta.tar.gz" | ||
| exit 1 | ||
| fi | ||
| tar -xzf /tmp/build-meta.tar.gz \ |
There was a problem hiding this comment.
The symlink/hardlink check uses tar -tvf /tmp/build-meta.tar.gz (without -z). On ubuntu runners, tar -tf/-tvf may not reliably read a .tar.gz without -z, which can cause the check to silently miss issues (especially since the pipeline doesn’t use pipefail). Prefer using tar -tzf/tar -tzvf consistently and enabling set -o pipefail (or set -euo pipefail) for this step so failures in tar make the step fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of what this PR does and why it's needed.
Type of Change
Related Issues
Closes #(issue number)
How Has This Been Tested?
Describe the tests you ran and how to reproduce them:
Checklist
Screenshots (if applicable)
Add screenshots for UI changes.
Additional Context
Add any other context about the PR here.