Skip to content

Fancy - v2.1.2

Choose a tag to compare

@ItsJonQ ItsJonQ released this 07 Nov 14:35
· 30 commits to master since this release

FrameManager: Fix IE/Edge frame rendering

screen recording 2018-11-06 at 05 24 pm

(GIF: Demo'ing Frame 1 being unmounted (destroy) and remounted in Edge. No errors in console. Stays are working)

This update fixes the iFrame SCRIPT70 error that occurs in IE/Edge
when an iFrame unmounts/remounts.

The solution was to wrap the offending code in a try/catch.

The code in question is designed for performance, specifically to check
for cached instances of Emotion, and serves that instance instead of
creating a brand new one.

The caching mechanism will work for all browsers excluding IE/Edge, which
unfortunately, will create new emotion instances every time as unmounted
frames cannot be properly references.

Tested on Edge, IE, and Chrome