Skip to content

Fancy - v2.3.0

Choose a tag to compare

@ItsJonQ ItsJonQ released this 11 Mar 16:59
· 12 commits to master since this release

Fix FrameProvider build for Babel 7 (Zero 3)

The issue came down to getEmotion from createFrameManager
https://github.com/helpscout/fancy/blob/master/src/create-emotion-styled/createFrameManager.js#L36

For some reason, changing the build from babel 6 -> 7 made this particular function not work as expected. Perhaps the update revealed some weaknesses in the logic.

The solution involved additional guards and a secondary argument to getEmotion:

getEmotion(frame, currentEmotion)

currentEmotion acts like a fallback. If any of the guards fail, that would be returned.
The method calling getEmotion also has additional guards!


Screencast:

https://www.useloom.com/share/10189a002d484e1b8ef91956a875f4ac


Resolves #42


  • Fix FrameProvider build for Babel 7 (Zero 3) (#44) e7d5c93

v2.2.6...v2.3.0