fix picture SPI Quarkus Arc crash + reorganise plugins + sops-nix docs#12
Merged
Merged
Conversation
Bug fix: Keycloak 26 boot fails with UnsatisfiedResolutionException for PictureConfig / S3Storage because Quarkus' Arc CDI scanner discovers ProfilePictureResource (has @path) and tries to bean-inject its constructor params, but the params are plain POJOs constructed manually by our factory. Fix: drop the resource constructor entirely. KeycloakSession is now injected via @context, and the per-instance config + S3Storage live in a new static PictureProviderHolder populated by the factory's init(). All helper classes (resource, holder, config, storage, image processor, multipart parser) are annotated @Vetoed so the scanner skips them. Folder reorganisation: - keycloak-extensions/turnstile-authenticator/ → captcha/ - keycloak-extensions/privacy-acceptance/ → privacy/ - keycloak-extensions/profile-picture/ → picture/ Matching artifactId rename to helpwave-{captcha,privacy,picture} so each plugin is short, standalone, and easy to grep. CI + README + deployment docs updated for the new jar names and paths. Deployment docs rewritten for sops-nix: - secrets/keycloak/r2-{access,secret}-key + turnstile-secret as sops.secrets, owned by keycloak with mode 0400. - sops.templates."keycloak.env" rendered to /run/secrets-rendered for the systemd EnvironmentFile (TURNSTILE_SECRET). - services.keycloak.settings uses _secret = sops.secrets.<name>.path, no /run/keys/ ad-hoc paths. New .env.example at repo root mirrors every variable from the NixOS config 1:1 so docker compose dev and prod deployments stay aligned. Version bumped to 0.4.0 to ship the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix: Keycloak 26 boot fails with
UnsatisfiedResolutionException for PictureConfig / S3Storage
because Quarkus' Arc CDI scanner discovers ProfilePictureResource (has @path) and tries to bean-inject its constructor params, but the params are plain POJOs constructed manually by our factory.
Fix: drop the resource constructor entirely. KeycloakSession is now injected via @context, and the per-instance config + S3Storage live in a new static PictureProviderHolder populated by the factory's init(). All helper classes (resource, holder, config, storage, image processor, multipart parser) are annotated @Vetoed so the scanner skips them.
Folder reorganisation:
Matching artifactId rename to helpwave-{captcha,privacy,picture} so
each plugin is short, standalone, and easy to grep.
CI + README + deployment docs updated for the new jar names and paths.
Deployment docs rewritten for sops-nix:
New .env.example at repo root mirrors every variable from the NixOS config 1:1 so docker compose dev and prod deployments stay aligned.
Version bumped to 0.4.0 to ship the fix.