Fix E2E failures in patient view related tasks panel#320
Merged
Conversation
- Stop infinite re-render when opening the Tasks tab on a saved patient view: sync related table state from memoized baselines and only when the persisted view definition key changes. - Fix virtual derived singleTag equals matching to use uuidValue like hightide and reject empty selections instead of matching every row. - Harden filter/sort E2E helpers for tabbed view pages (visible toolbar controls and dialog-scoped equals tag filters). - Move Playwright config to tests/playwright.config.ts with correct paths so CI/local runs pick up baseURL, retries, and webServer settings. Co-authored-by: Felix Evers <social@felixevers.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigates and fixes the E2E failure introduced with the filter/sort saved-view tests in #319.
PatientViewTasksPanelreset related table state on every render because the syncuseEffectdeserialized fresh[]arrays and depended on unstable setter identities fromuseColumnVisibilityWithPropertyDefaults.equalsmatching invirtualDerivedTableStatealso treated an empty selection as "match all".tests/e2e/with an incorrecttestDir, sonpx playwright testfromtests/ignored CI settings. Filter helpers now target visible controls on tabbed view pages.Changes
PatientViewTasksPanel: memoize main view filters/sorting; sync related state from memoized baselines only whenpersistedRelatedContentKeychanges.virtualDerivedTableState: align singleTagequals/containsmatching with hightide semantics (uuidValue, no match-all on empty selection).filterSortUi.ts: visible toolbar/popup scoping +addSingleTagEqualsFilterhelper.tests/playwright.config.ts: correct config location and paths.Validation
CI=true E2E_BASE_URL=http://localhost:3000 npx playwright test— 53 passed