Remove unneeded privileges from nfsrods#160
Merged
mac-chaffee merged 2 commits intodevelopfrom Feb 7, 2022
Merged
Conversation
pj-linebaugh
requested changes
Feb 7, 2022
Contributor
pj-linebaugh
left a comment
pj-linebaugh
left a comment
There was a problem hiding this comment.
Can you also increase the helx parent chart version?
pj-linebaugh
approved these changes
Feb 7, 2022
Contributor
|
NVM about that helx parent chart version. I'm working on another branch for nfsrods with that updated. i'll merge that soon hopefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NFSrods performs the NFS operations entirely in userspace, so as a result it does not need privileged access to the underlying OS. PJ, Warren, and I have tested this change in Sterling (where privileged pods are not allowed since they break multi-tenancy) and nfsrods appears to run happily.