support fastify 3.x - node >=10 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashpie
commented
Aug 8, 2020
StarpTech
approved these changes
Aug 9, 2020
| "fastify-plugin": "^2.2.0", | ||
| "nats": "1.4.12", | ||
| "nats-hemera": "^7.0.2", | ||
| "tap": "^14.10.8" |
Contributor
Author
There was a problem hiding this comment.
Sure, reason for upgrade is that tests are using those too... at least fastify-plugin needs an upgrade to support fastify 3 - new tap comes with built in spec reporter
Member
|
@mashpie Would you mind creating a simple Github Action to enable tests on push? It's also ok to do it afterward. |
Contributor
Author
|
Well, yes I could look into this. To me this looks a bit out-of-scope of the current PR. So for now I think the existing travis setup is just fine and working https://travis-ci.com/github/uscreen/fastify-hemera/builds/179037444 |
Member
|
Alright 👍 |
Member
|
@mashpie The new version was released https://github.com/hemerajs/fastify-hemera/releases/tag/v10.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for this module!
We've been using it successfully with fastify 2.x. Now as I was starting to check for upgrades and migration options I found fastify-hemera sticking to
^2.0.0. Turned out to be working without change in 3.2.x. This PR is basically just changing that version to>=2.0.0.But as I wanted proper tests I added some notes to readme and upgraded fastify and related dependencies. This introduced a new version of
serverwhich dropped support for node 8:That's why this PR also changes node support and covers versions from 10 to 14 in travis.