Update from upstream#2
Merged
Merged
Conversation
Co-authored-by: Rahul Dalal <rahul@succinct.xyz> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* initial attempt * regenerate wrap_vk; some fixes * remove println * turn on the sp1-gpu-prover experimental feature under the node feature * restore vk_tree_height
feat: grinding on batch basefold
* fix: ALU operations with rd = x0 * remove println --------- Co-authored-by: Eugene Rabinovich <eugene@succinct.xyz> Co-authored-by: tamirhemo <tamirhmo@gmail.com>
Co-authored-by: Eugene Rabinovich <eugene@succinct.xyz>
Co-authored-by: Eugene Rabinovich <eugene@succinct.xyz>
* correct vk_map * wrap and verifier vk artifacts * Turn vk verification on in CI; restore verifier crate tests
Co-authored-by: fakedev9999 <fakedev9999@users.noreply.github.com>
Co-authored-by: qwang98 <qian.wang.wg24@wharton.upenn.edu> Co-authored-by: Georg Wiese <georgwiese@gmail.com>
Co-authored-by: qwang98 <qian.wang.wg24@wharton.upenn.edu> Co-authored-by: Georg Wiese <georgwiese@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…refix (#2785) Co-authored-by: Claude <noreply@anthropic.com>
…bits grows (#2775) Co-authored-by: Tamir Hemo <tamir@succinct.xyz>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…2754) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…2793) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
max-sanchez
added a commit
that referenced
this pull request
May 27, 2026
…grams Pointed the microbench harness at #2.2 (InstructionFetch / InstructionDecode generate_trace_into, which compute a chunk_size but iterate sequentially with no rayon). The bench prints the event count, which immediately settled it: instr_fetch/fibonacci (0 ev) ~600 ns instr_fetch/sha2 (0 ev) ~594 ns instr_decode/fibonacci ~34 ns instr_decode/sha2 ~34 ns For trusted programs (all normal workloads) `instruction_fetch_events` is EMPTY — these chips only carry per-instruction rows when `enable_untrusted_programs` is set. So parallelizing their trace-gen is a no-op for the common case; the 17-agent review's "= total executed instructions" premise was untrusted-mode-only. ByteChip/RangeChip (the other half of #2.2) iterate the bounded byte_lookups domain (~tens of thousands of entries, sub-ms even sequential) and write indexed cells that are awkward to parallelize safely. Verdict: skip #2.2 for trusted workloads. Records the finding in the 5090 plan (#2.2 marked rejected) and keeps the bench as a reusable chip-tracegen template (and to measure these chips under untrusted-program workloads). Third harness-driven decision after keeping #1.5a (real win) and reverting #1.5c (regression). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.