perf: reduce stream abuse in hot paths#296
Closed
Vonr wants to merge 6 commits intohenkelmax:1.21.1from
Closed
Conversation
Owner
|
Please target the master branch for PRs |
Author
|
I am unable to build the master branch as corelib 2.1.12+26.1.2 is not publically available |
Author
|
Considering the mod hasn't been updated for 1.21.1 in 2 years, I'll probably port this optimization into https://github.com/Vonr/invasiveopts as well. |
Vonr
added a commit
to Vonr/invasiveopts
that referenced
this pull request
May 1, 2026
Author
|
I'll close this for now, but do remind me if you fix corelib's unavailability and I will open a PR targeting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes abuses of streams in
UpgradeTileEntity#getSortedConnectionsand various*PipeType#canInsertimplementations, which should reduce allocation rate and lead to increased performance