-
Notifications
You must be signed in to change notification settings - Fork 1
gh-212: metadata for bias computation #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Try |
fc5ab14 to
b9a05a3
Compare
Nice git arcane magic! |
ntessore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Weights class doesn't have the extra metadata yet. We should also
- figure out better names for the metadata, particularly
variance, which isn't the variance; - figure out whether to store density and effective density separately.
Let's discuss offline.
Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
Co-authored-by: Nicolas Tessore <n.tessore@ucl.ac.uk>
ntessore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work 🎉
Adds more metadata to the maps' fields used to compute the Jacknife covariance matrix.
The history of the branch seems linked to my previous PR??