You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey there, I'm loving herdr, and I recently used its worktree-listing functionality for the first time, where I ran in to a small friction.
I've configured my sidebar spaces with the repo name on line 1 and dimmed detail below it:
[ui.sidebar.spaces]
rows = [
["state_icon", "workspace"],
[{ token = "branch", dim = true }, { token = "git_status", dim = true }],
[{ token = "$jj_bookmark", dim = true }, { token = "$jj_status", dim = true }],
]
On worktree child rows however, the branch token comes out not dimmed, and I couldn't find any config for it. AFAICT in 0.8.0, an indented child row does two things: grouped_child_display_label substitutes the branch text into the workspace token, and suppress_git_details drops branch and git_status. So IIUC my second row resolves to nothing and thus the branch ends up rendered with the workspace name style rather than the style I set on the branch token.
I could do { token = "workspace", dim = true }, but that dims top-level repo names too, which defeats the point.
requested change
What I'd like is to style child rows independently, e.g. an optional override next to rows, something like:
This would let me keep sidebar theming consistent WRT the coloring of secondary rows. I've noticed it also overlaps with #1485, which runs into the same two mechanisms from the content side (wanting folder and branch on children); I believe one child-row override would cover both cases. And #2321 is also asking for a worktree-specific key in this table.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
idea / problem
Hey there, I'm loving
herdr, and I recently used its worktree-listing functionality for the first time, where I ran in to a small friction.I've configured my sidebar spaces with the repo name on line 1 and dimmed detail below it:
On worktree child rows however, the branch token comes out not dimmed, and I couldn't find any config for it. AFAICT in
0.8.0, an indented child row does two things:grouped_child_display_labelsubstitutes the branch text into theworkspacetoken, andsuppress_git_detailsdropsbranchandgit_status. So IIUC my second row resolves to nothing and thus the branch ends up rendered with theworkspacename style rather than the style I set on thebranchtoken.I could do
{ token = "workspace", dim = true }, but that dims top-level repo names too, which defeats the point.requested change
What I'd like is to style child rows independently, e.g. an optional override next to
rows, something like:why you want this
This would let me keep sidebar theming consistent WRT the coloring of secondary rows. I've noticed it also overlaps with #1485, which runs into the same two mechanisms from the content side (wanting folder and branch on children); I believe one child-row override would cover both cases. And #2321 is also asking for a worktree-specific key in this table.
All reactions