Skip to content

Apply lint config in exec configuration#2

Merged
dzbarsky merged 1 commit intomainfrom
isaacparker-lintExecConfig
Feb 20, 2026
Merged

Apply lint config in exec configuration#2
dzbarsky merged 1 commit intomainfrom
isaacparker-lintExecConfig

Conversation

@isaacparker0
Copy link
Copy Markdown
Collaborator

@isaacparker0 isaacparker0 commented Feb 20, 2026

Previously lint_config was not applied for targets building in the exec configuration, but I think lint config should always be respected as it's the target's explicit intent. The original justification of preventing crates used in build scripts from generating warnings seems spurious to me, and it's not clear to me why target vs. exec configuration should affect how source code is linted. A real example where this is problematic:

  • a codebase defines a lint config to disable a default rustc lint.
  • now building some workspace crate in the exec configuration will always show that warning with no way to suppress it.

@isaacparker0 isaacparker0 changed the title 0 Apply lint config in exec configuration Feb 20, 2026
@dzbarsky dzbarsky merged commit 550160d into main Feb 20, 2026
1 check failed
dzbarsky pushed a commit that referenced this pull request Feb 20, 2026
dzbarsky pushed a commit that referenced this pull request Feb 23, 2026
dzbarsky pushed a commit that referenced this pull request Feb 26, 2026
dzbarsky pushed a commit that referenced this pull request Mar 3, 2026
dzbarsky pushed a commit that referenced this pull request Mar 5, 2026
dzbarsky pushed a commit that referenced this pull request Mar 8, 2026
dzbarsky pushed a commit that referenced this pull request Mar 13, 2026
dzbarsky pushed a commit that referenced this pull request Apr 1, 2026
dzbarsky pushed a commit that referenced this pull request Apr 14, 2026
dzbarsky pushed a commit that referenced this pull request Apr 15, 2026
dzbarsky pushed a commit that referenced this pull request Apr 16, 2026
dzbarsky pushed a commit that referenced this pull request Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants