Regression 0.13: Uhyve-FS mounts fail.

[jounathaen]

Since 0.13, it seems that mounting a directory fails. I'm currently investigating the details.

[fogti]

Hey, this gets fixed by #2301

[fogti]

I can also give you the details:

• PR refactor: do more early returns #2249 introduced the problem that instead of mounting all given uhyve directories, it stops after the first one. In the uhyve tests, this shows up as the mounts_test failing either at the first or second file (depending on if the first file tested is contained in the first directory given via FDT or not; and the order of mounts in the FDT appears to be random). It was particularly disturbing (looked like a race condition), so I grabbed quite heavy tools to investigate (logging all hypercalls and running uhyve through strace). I face-palmed quite hard when I realized the fix was a one-liner. Thanks to HERMIT_MANIFEST_DIR, at least testing was easy.
• PR fix(fs/uhyve): Mount all uhyve directories #2301 fixes that.