Enhanced uhyve memory detection #1391
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jounathaen
force-pushed
the
uhyve-mem
branch
from
cf5a6b6 to
9b52959
Compare
jounathaen
force-pushed
the
uhyve-mem
branch
from
9b52959 to
4777319
Compare
Member
|
Note that hermit-os/uhyve#758 would make |
mkroening
requested changes
Oct 11, 2024
Member
mkroening
left a comment
mkroening
left a comment
There was a problem hiding this comment.
detect_from_uhyve is inactive since hermit-os/uhyve#758.
Member
Author
|
Despite this being not relevant for new Uhyve versions, I think this code still contains some improvements to the memory detection code. Is it worth rebasing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current memory detection relies on some moreless undocumented assumptions about how uhyve prepares the memory. However, we do get all the information in the boot-info to determine the memory correctly.
This is one step in enabling "ASLR-like" arbitrary memory locations for hermit (hermit-os/uhyve#725)