Skip to content

refactor(logging): make time formatting more explicit#2432

Merged
mkroening merged 2 commits into
hermit-os:mainfrom
cagatay-y:refactor-logging
May 28, 2026
Merged

refactor(logging): make time formatting more explicit#2432
mkroening merged 2 commits into
hermit-os:mainfrom
cagatay-y:refactor-logging

Conversation

@cagatay-y

Copy link
Copy Markdown
Contributor

No description provided.

@cagatay-y cagatay-y force-pushed the refactor-logging branch 2 times, most recently from c888639 to 039d518 Compare May 13, 2026 15:08

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: 8159358 Previous: ede71c0 Performance Ratio
startup_benchmark Build Time 104.88 s 99.20 s 1.06
startup_benchmark File Size 0.75 MB 0.76 MB 1.00
Startup Time - 1 core 0.97 s (±0.04 s) 0.94 s (±0.04 s) 1.04
Startup Time - 2 cores 0.99 s (±0.05 s) 0.96 s (±0.05 s) 1.04
Startup Time - 4 cores 0.97 s (±0.05 s) 0.96 s (±0.04 s) 1.01
multithreaded_benchmark Build Time 105.94 s 107.20 s 0.99
multithreaded_benchmark File Size 0.87 MB 0.86 MB 1.01
Multithreaded Pi Efficiency - 2 Threads 85.58 % (±18.26 %) 91.00 % (±14.55 %) 0.94
Multithreaded Pi Efficiency - 4 Threads 41.96 % (±8.71 %) 45.27 % (±7.73 %) 0.93
Multithreaded Pi Efficiency - 8 Threads 22.95 % (±4.22 %) 24.88 % (±3.26 %) 0.92
micro_benchmarks Build Time 86.61 s 92.81 s 0.93
micro_benchmarks File Size 0.87 MB 0.86 MB 1.01
Scheduling time - 1 thread 69.03 ticks (±4.05 ticks) 68.53 ticks (±3.92 ticks) 1.01
Scheduling time - 2 threads 38.90 ticks (±4.38 ticks) 39.67 ticks (±4.24 ticks) 0.98
Micro - Time for syscall (getpid) 3.62 ticks (±0.33 ticks) 2.95 ticks (±0.28 ticks) 1.23
Memcpy speed - (built_in) block size 4096 81248.56 MByte/s (±56071.50 MByte/s) 79590.12 MByte/s (±55157.77 MByte/s) 1.02
Memcpy speed - (built_in) block size 1048576 30133.38 MByte/s (±24456.61 MByte/s) 29900.58 MByte/s (±24427.92 MByte/s) 1.01
Memcpy speed - (built_in) block size 16777216 29203.61 MByte/s (±24110.38 MByte/s) 29198.54 MByte/s (±24141.87 MByte/s) 1.00
Memset speed - (built_in) block size 4096 80958.23 MByte/s (±55882.03 MByte/s) 79808.67 MByte/s (±55316.96 MByte/s) 1.01
Memset speed - (built_in) block size 1048576 30841.07 MByte/s (±24864.04 MByte/s) 30660.50 MByte/s (±24865.67 MByte/s) 1.01
Memset speed - (built_in) block size 16777216 29949.40 MByte/s (±24527.67 MByte/s) 29947.79 MByte/s (±24563.56 MByte/s) 1.00
Memcpy speed - (rust) block size 4096 70366.87 MByte/s (±49011.79 MByte/s) 71838.02 MByte/s (±50156.20 MByte/s) 0.98
Memcpy speed - (rust) block size 1048576 29882.79 MByte/s (±24384.00 MByte/s) 29850.23 MByte/s (±24412.52 MByte/s) 1.00
Memcpy speed - (rust) block size 16777216 29274.67 MByte/s (±24186.34 MByte/s) 29179.09 MByte/s (±24119.28 MByte/s) 1.00
Memset speed - (rust) block size 4096 70745.81 MByte/s (±49257.92 MByte/s) 72078.48 MByte/s (±50299.01 MByte/s) 0.98
Memset speed - (rust) block size 1048576 30650.72 MByte/s (±24826.51 MByte/s) 30581.94 MByte/s (±24812.57 MByte/s) 1.00
Memset speed - (rust) block size 16777216 30048.09 MByte/s (±24628.38 MByte/s) 29935.12 MByte/s (±24543.49 MByte/s) 1.00
alloc_benchmarks Build Time 85.80 s 85.84 s 1.00
alloc_benchmarks File Size 0.83 MB 0.84 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 4555.27 Ticks (±59.43 Ticks) 4581.75 Ticks (±1166.54 Ticks) 0.99
Allocations - Average Allocation time (no fail) 4555.27 Ticks (±59.43 Ticks) 4581.75 Ticks (±1166.54 Ticks) 0.99
Allocations - Average Deallocation time 1079.83 Ticks (±70.90 Ticks) 878.84 Ticks (±180.10 Ticks) 1.23
mutex_benchmark Build Time 84.35 s 101.79 s 0.83
mutex_benchmark File Size 0.87 MB 0.87 MB 1.01
Mutex Stress Test Average Time per Iteration - 1 Threads 12.74 ns (±0.77 ns) 13.22 ns (±0.73 ns) 0.96
Mutex Stress Test Average Time per Iteration - 2 Threads 17.94 ns (±10.16 ns) 19.06 ns (±1.33 ns) 0.94

This comment was automatically generated by workflow using github-action-benchmark.

@mkroening mkroening self-requested a review May 13, 2026 15:36
@mkroening mkroening self-assigned this May 13, 2026

@mkroening mkroening left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Duration is twice as large as the previous u64, but I think this is still fine. 👍

@mkroening mkroening enabled auto-merge May 28, 2026 09:54
@mkroening mkroening added this pull request to the merge queue May 28, 2026
Merged via the queue into hermit-os:main with commit 38bff4c May 28, 2026
20 checks passed
@cagatay-y cagatay-y deleted the refactor-logging branch May 28, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants