Rewrite cross-note .md links to Jekyll permalinks at build time#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently the build script only rewrites image paths. Cross-note links like `taste` are emitted verbatim, so they 404 on the published Jekyll site (which serves posts at `/{stem}` per the site's `/:title` permalink config).
This patch adds a regex pass over each note's body that rewrites `label` (with optional leading `./`) to `label`. Anchors are preserved. Image links are excluded by the leading-`!` lookbehind.
A first pass collects the set of stems whose front matter has `publish: true`. Links to non-publishable or missing targets are left untouched and logged as a WARN to stderr — useful signal without breaking the build.
Test plan