Stop manually creating a src dir in the pip dependencies layer#228
Merged
Conversation
Since Pip will create the directory itself if needed (which is only when there are editable mode VCS dependencies being installed). This behaviour is already tested, via: https://github.com/heroku/buildpacks-python/blob/ff51b31c65cbd1932fc4cdc585c60942efcfe836/tests/pip_test.rs#L197-L216
dzuelke
approved these changes
Jul 19, 2024
This was referenced Aug 1, 2024
Merged
src dir in the Pip dependencies layersrc dir in the pip dependencies layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since pip will create the directory itself if needed (which is only when there are editable mode VCS dependencies being installed).
This behaviour is already tested, via:
buildpacks-python/tests/pip_test.rs
Lines 197 to 216 in ff51b31
GUS-W-16390558.