Stop using --link when running Django collectstatic#339
Merged
Conversation
Since: - It causes collectstatic to fail if the app is using a Django remote storage backend (such as one that stores static assets on S3). - Using `--link` provides little benefit to apps using local storage when using WhiteNoise configured with `WHITENOISE_KEEP_ONLY_HASHED_FILES=True` (as the Python Getting Started Guide does) See: - #328 - https://docs.djangoproject.com/en/5.1/ref/contrib/staticfiles/#collectstatic Fixes #328. GUS-W-17799386.
edmorley
force-pushed
the
django-collectstatic-no-link
branch
from
c5c3dff to
6b83777
Compare
schneems
approved these changes
Mar 11, 2025
Merged
heroku-linguist Bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Mar 11, 2025
## heroku/python ### Changed - Stopped using `--link` when running Django's collectstatic command, since it doesn't work with remote storage backends. ([#339](heroku/buildpacks-python#339))
heroku-linguist Bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Mar 11, 2025
## heroku/python ### Changed - Stopped using `--link` when running Django's collectstatic command, since it doesn't work with remote storage backends. ([#339](heroku/buildpacks-python#339)) Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since:
--linkprovides little benefit to apps using local storage when using WhiteNoise configured withWHITENOISE_KEEP_ONLY_HASHED_FILES=True(as the Python Getting Started Guide does)See:
--link#328Fixes #328.
GUS-W-17799386.