Merged
Conversation
edmorley
force-pushed
the
forbidden-env-vars-check
branch
from
eeec09b to
1682f69
Compare
edmorley
force-pushed
the
forbidden-env-vars-check
branch
from
1682f69 to
e766ac6
Compare
- Now reports all forbidden env vars found in one go, rather than only the first found. - Now checks for known problematic Poetry env vars too. - Uses a const slice instead of a fixed size array to avoid having to manually update the array every time entries are added/removed. - Uses a static str slice in the error to avoid an unnecessary string allocation. - Adds additional unit test coverage. GUS-W-21914465.
edmorley
force-pushed
the
forbidden-env-vars-check
branch
from
e766ac6 to
c587780
Compare
runesoerensen
approved these changes
Apr 7, 2026
heroku-linguist bot
added a commit
that referenced
this pull request
Apr 7, 2026
## heroku/python ### Changed - The Python 3.14 version alias now resolves to Python 3.14.4. ([#548](#548)) - The Python 3.13 version alias now resolves to Python 3.13.13. ([#548](#548)) - The forbidden env vars check now reports all forbidden env vars found rather than only the first. ([#542](#542)) - The forbidden env vars check now checks for known problematic Poetry env vars too. ([#542](#542))
Merged
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Apr 7, 2026
## heroku/python ### Changed - The Python 3.14 version alias now resolves to Python 3.14.4. ([#548](heroku/buildpacks-python#548)) - The Python 3.13 version alias now resolves to Python 3.13.13. ([#548](heroku/buildpacks-python#548)) - The forbidden env vars check now reports all forbidden env vars found rather than only the first. ([#542](heroku/buildpacks-python#542)) - The forbidden env vars check now checks for known problematic Poetry env vars too. ([#542](heroku/buildpacks-python#542))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GUS-W-21914465.