Skip to content

Rewrite of TPS integrations using basic bash scripts#3090

Merged
mars merged 19 commits intomainfrom
tps-integration
Nov 19, 2024
Merged

Rewrite of TPS integrations using basic bash scripts#3090
mars merged 19 commits intomainfrom
tps-integration

Conversation

@mars
Copy link
Member

@mars mars commented Nov 13, 2024

Through work & pairing with @halorgium, we've got a more testable approach for CLI's TPS integrations.

The scripts release/tps_check_lock& postrelease/tps_record_release are now similar bash scripts, making these much easier to reason about.

They each:

  1. parse env vars & arguments, returning clear error messages for missing inputs
  2. implemented as a single curl command capturing response status code and response body
  3. retry using a basic loop, with sensible timeouts for each
    1. 10-minutes for checking the lock
    2. 30-minutes for recording the release
  4. logs clear error message (response status & body) during retries

@mars mars temporarily deployed to AcceptanceTests November 13, 2024 19:28 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 13, 2024 19:28 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 13, 2024 19:30 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 13, 2024 19:30 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 13, 2024 19:52 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 13, 2024 19:52 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 13, 2024 20:03 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 13, 2024 20:03 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 13, 2024 23:37 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 13, 2024 23:37 — with GitHub Actions Inactive
@mars mars changed the title Speculative rewrite of TPS lock check Rewrite of TPS integrations using basic bash scripts Nov 13, 2024
@mars mars temporarily deployed to AcceptanceTests November 13, 2024 23:58 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 13, 2024 23:58 — with GitHub Actions Inactive
@mars mars requested a review from k80bowman November 14, 2024 00:02
@mars mars temporarily deployed to AcceptanceTests November 14, 2024 00:03 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 14, 2024 00:03 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 14, 2024 01:05 — with GitHub Actions Inactive
@mars mars marked this pull request as ready for review November 14, 2024 01:08
@mars mars requested a review from a team as a code owner November 14, 2024 01:08
@mars mars requested a review from eablack November 14, 2024 01:09
@mars mars temporarily deployed to AcceptanceTests November 14, 2024 18:02 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 14, 2024 18:02 — with GitHub Actions Inactive
Copy link
Contributor

@eablack eablack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm! had one thing i noticed that should be fixed and one question/comment.

@mars mars temporarily deployed to AcceptanceTests November 14, 2024 23:22 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 14, 2024 23:22 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 14, 2024 23:23 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 14, 2024 23:23 — with GitHub Actions Inactive
@mars
Copy link
Member Author

mars commented Nov 14, 2024

Thanks for the tight reviews y'all! Please give it your ✅ approval or more feedback for changes.

@mars mars temporarily deployed to AcceptanceTests November 14, 2024 23:30 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 14, 2024 23:30 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 14, 2024 23:33 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 14, 2024 23:33 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 15, 2024 01:00 — with GitHub Actions Inactive
@mars mars temporarily deployed to AcceptanceTests November 15, 2024 01:00 — with GitHub Actions Inactive
Copy link
Contributor

@halorgium halorgium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome.

@mars mars merged commit cf9b89d into main Nov 19, 2024
@mars mars deleted the tps-integration branch November 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants