Rewrite of TPS integrations using basic bash scripts#3090
Merged
Conversation
1991c07 to
13226f0
Compare
halorgium
reviewed
Nov 14, 2024
eablack
reviewed
Nov 14, 2024
Contributor
eablack
left a comment
There was a problem hiding this comment.
mostly lgtm! had one thing i noticed that should be fixed and one question/comment.
Member
Author
|
Thanks for the tight reviews y'all! Please give it your ✅ approval or more feedback for changes. |
eablack
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Through work & pairing with @halorgium, we've got a more testable approach for CLI's TPS integrations.
The scripts
release/tps_check_lock&postrelease/tps_record_releaseare now similar bash scripts, making these much easier to reason about.They each:
curlcommand capturing response status code and response body