refactor: convert accounts commands to esm#3309
Merged
Conversation
eablack
force-pushed
the
eb/convert-accounts-esm
branch
from
22fc6ec to
f70bc43
Compare
eablack
force-pushed
the
v11.0.0
branch
2 times, most recently
from
b446fce to
dcbe941
Compare
* Comment out tests * Upgrade to oclif/core v4, comment out most commands, libs, and tests * move to esm * Update dev/run commands, convert tests to esm * Make tests compatible with ESM * revert log-displayer to commonjs * Uncomment regions, add some tests back * Update yarn.lock * Comment out new commands from pg upgrade * Adjust tests to account for variable table length * Fix regions test, add stuff back to bin/run and update bin/dev * fix lint * Remove temp script * Update heroku-cli/command * Add esm ts-node option to tsconfig.json * Update requires to imports, switch to cli-progress from smooth-progress * Update to modern module resolution * Rewrite Editor to stop using ancient library * Update a few packages * Remove shellescape, fix lint * Update to esm version of heroku-cli/command
* Upgrade to oclif/core v4, comment out most commands, libs, and tests * Update oclif dependencies to latest * refactor!: convert to esm (#3301) * Comment out tests * Upgrade to oclif/core v4, comment out most commands, libs, and tests * move to esm * Update dev/run commands, convert tests to esm * Make tests compatible with ESM * revert log-displayer to commonjs * Uncomment regions, add some tests back * Update yarn.lock * Comment out new commands from pg upgrade * Adjust tests to account for variable table length * Fix regions test, add stuff back to bin/run and update bin/dev * fix lint * Remove temp script * Update heroku-cli/command * Add esm ts-node option to tsconfig.json * Update requires to imports, switch to cli-progress from smooth-progress * Update to modern module resolution * Rewrite Editor to stop using ancient library * Update a few packages * Remove shellescape, fix lint * Update to esm version of heroku-cli/command * add back access and 2fa commands * Add token, logout, 2fa, and fix tests. * Update runcommand, tests * Update tests * Add expects for empty stdout * Replace with temporary test * Update timeout to match what we originally had * fix yarn.lock * update test * Stub ux.action, update tests * Update logout test
eablack
force-pushed
the
eb/convert-accounts-esm
branch
from
f70bc43 to
2dc6ade
Compare
eablack
changed the title
k80bowman
approved these changes
Jun 12, 2025
Contributor
k80bowman
left a comment
k80bowman
left a comment
There was a problem hiding this comment.
I had one question, but it's not blocking. Looks good!
eablack
added a commit
that referenced
this pull request
Jun 25, 2025
* Upgrade to oclif/core v4, comment out most commands, libs, and tests * Update oclif dependencies to latest * refactor!: convert to esm (#3301) * Comment out tests * Upgrade to oclif/core v4, comment out most commands, libs, and tests * move to esm * Update dev/run commands, convert tests to esm * Make tests compatible with ESM * revert log-displayer to commonjs * Uncomment regions, add some tests back * Update yarn.lock * Comment out new commands from pg upgrade * Adjust tests to account for variable table length * Fix regions test, add stuff back to bin/run and update bin/dev * fix lint * Remove temp script * Update heroku-cli/command * Add esm ts-node option to tsconfig.json * Update requires to imports, switch to cli-progress from smooth-progress * Update to modern module resolution * Rewrite Editor to stop using ancient library * Update a few packages * Remove shellescape, fix lint * Update to esm version of heroku-cli/command * Fix bin/run, run yarn install * refactor: add back access and 2fa commands (#3304) * Upgrade to oclif/core v4, comment out most commands, libs, and tests * Update oclif dependencies to latest * refactor!: convert to esm (#3301) * Comment out tests * Upgrade to oclif/core v4, comment out most commands, libs, and tests * move to esm * Update dev/run commands, convert tests to esm * Make tests compatible with ESM * revert log-displayer to commonjs * Uncomment regions, add some tests back * Update yarn.lock * Comment out new commands from pg upgrade * Adjust tests to account for variable table length * Fix regions test, add stuff back to bin/run and update bin/dev * fix lint * Remove temp script * Update heroku-cli/command * Add esm ts-node option to tsconfig.json * Update requires to imports, switch to cli-progress from smooth-progress * Update to modern module resolution * Rewrite Editor to stop using ancient library * Update a few packages * Remove shellescape, fix lint * Update to esm version of heroku-cli/command * add back access and 2fa commands * Add token, logout, 2fa, and fix tests. * Update runcommand, tests * Update tests * Add expects for empty stdout * Replace with temporary test * Update timeout to match what we originally had * fix yarn.lock * update test * Stub ux.action, update tests * Update logout test * Add accounts index command back, wrap accounts function in new class module * Move everything into wrapper, rename wrapper to just accounts * Convert current/remove commands for accounts * convert add and set for accounts commands * Update yarn.lock * Remove duplicates * Fix commenting out of test * be consistent with imported module capitalization
eablack
added a commit
that referenced
this pull request
Jul 17, 2025
* Upgrade to oclif/core v4, comment out most commands, libs, and tests * Update oclif dependencies to latest * refactor!: convert to esm (#3301) * Comment out tests * Upgrade to oclif/core v4, comment out most commands, libs, and tests * move to esm * Update dev/run commands, convert tests to esm * Make tests compatible with ESM * revert log-displayer to commonjs * Uncomment regions, add some tests back * Update yarn.lock * Comment out new commands from pg upgrade * Adjust tests to account for variable table length * Fix regions test, add stuff back to bin/run and update bin/dev * fix lint * Remove temp script * Update heroku-cli/command * Add esm ts-node option to tsconfig.json * Update requires to imports, switch to cli-progress from smooth-progress * Update to modern module resolution * Rewrite Editor to stop using ancient library * Update a few packages * Remove shellescape, fix lint * Update to esm version of heroku-cli/command * Fix bin/run, run yarn install * refactor: add back access and 2fa commands (#3304) * Upgrade to oclif/core v4, comment out most commands, libs, and tests * Update oclif dependencies to latest * refactor!: convert to esm (#3301) * Comment out tests * Upgrade to oclif/core v4, comment out most commands, libs, and tests * move to esm * Update dev/run commands, convert tests to esm * Make tests compatible with ESM * revert log-displayer to commonjs * Uncomment regions, add some tests back * Update yarn.lock * Comment out new commands from pg upgrade * Adjust tests to account for variable table length * Fix regions test, add stuff back to bin/run and update bin/dev * fix lint * Remove temp script * Update heroku-cli/command * Add esm ts-node option to tsconfig.json * Update requires to imports, switch to cli-progress from smooth-progress * Update to modern module resolution * Rewrite Editor to stop using ancient library * Update a few packages * Remove shellescape, fix lint * Update to esm version of heroku-cli/command * add back access and 2fa commands * Add token, logout, 2fa, and fix tests. * Update runcommand, tests * Update tests * Add expects for empty stdout * Replace with temporary test * Update timeout to match what we originally had * fix yarn.lock * update test * Stub ux.action, update tests * Update logout test * Add accounts index command back, wrap accounts function in new class module * Move everything into wrapper, rename wrapper to just accounts * Convert current/remove commands for accounts * convert add and set for accounts commands * Update yarn.lock * Remove duplicates * Fix commenting out of test * be consistent with imported module capitalization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W-18575885
Description
This uncomments auth and access commands and make them compatible with oclif/core v4. I also had to restructure the
accountslib as a library to make it easier to stub within ESM context.Testing
yarn build./bin/run accounts./bin/run accounts:current