Merged
Conversation
eablack
added a commit
that referenced
this pull request
Jul 17, 2025
* convert certs:add to esm * convert certs:generate to esm * Convert certs:index to esm * convert certs:info to esm * convert certs:remove to esm * convert certs:update to esm * convert certs auto refresh, disable, enable, index to esm * Fix shared cert update tests * Fix issue with lolex had with ink. Switch to explicitly stubbing date.now * Fix inquirer usage, revert lolex updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W-18575907
Description
This converts the
certscommands to esm and makes them availabe in the v11 branch. This PR involves a lot of formatting changes (like, for instance, adding.jsto imports), and also refactors a few things to make them easier to stub in a test within an esm world:This also deletes the
certs:auto:waitcommand, which was hidden and didn't actually do anything. Seems to have been left in a "to be implemented" state, and never implemented.There was an interesting interaction I discovered where our new table implementation (which uses ink under the covers) really doesn't like us messing with timeouts.
lolexwas breaking a test, so I implemented the time freeze in another way. This can be seen here: https://github.com/heroku/cli/pull/3327/files#diff-4ef25adc806db52a740fe9bdde046dcf777f073c47badf0e1340b78323765f79R590-R594A minor bug was also uncovered in a different command, apps:transfer related to inquirer. That has been fixed
Testing
For destructive actions (e.g.,
certs:add) please make sure to use a test app. We don't want to make certs changes to production or staging apps.yarn build./bin/run certs --app APPwhere APP has a cert./bin/run certs:generate --app APPwhere APP is test app./bin/run certs:add --app APPwhere APP is a test app./bin/run certs:auto:enable -app APPwhere APP is a test app./bin/run certs:auto:disable -app APPwhere APP is a test app