Conversation
sbosio
approved these changes
Jul 17, 2025
Contributor
sbosio
left a comment
sbosio
left a comment
There was a problem hiding this comment.
LGTM! All manual smoke tests ran successfully.
eablack
added a commit
that referenced
this pull request
Jul 17, 2025
* convert ci commands to oclif * Add back tests for info, last, rerun, run * Add index test back * fix index tests, convert pipelines helper into class * Update tests * Fix test * fix test * Add migrate-manifest test back * Add back tests for ci:config * Remove comments, app flag requirement * Clean up types, replace validator with custom checkers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W-18575909
Description
This converts
ci,ci:configcommands and its associated tests to esm. A minor bug was fixed along with this --heroku ci:openshould not require the --app flag as it does in v10.Testing
yarn install && yarn build./bin/run ci --pipeline PIPELINEwhere PIPELINE is a pipeline with heroku ci activated and has some tests./bin/run ci --app APPwhere APP is an app in PIPELINE./bin/run ci:last --pipeline PIPELINE./bin/run ci:open --pipeline PIPELINE./bin/run ci:run --pipeline PIPELINE./bin/run ci:config --pipeline PIPELINE./bin/run ci:config:get --pipeline PIPELINE KEYwhere KEY is a conig var within PIPELINE's ci config vars