refactor: convert drains commands to esm#3373
Merged
erika-wallace merged 5 commits intov11.0.0from Sep 18, 2025
Merged
Conversation
tlowrimore-heroku
approved these changes
Sep 18, 2025
Contributor
tlowrimore-heroku
left a comment
tlowrimore-heroku
left a comment
There was a problem hiding this comment.
@erika-wallace Nicely done! I like your solution to partitioning drains on with/without addons!
erika-wallace
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
erika-wallace
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
erika-wallace
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
erika-wallace
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
erika-wallace
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
erika-wallace
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
erika-wallace
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
erika-wallace
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
zwhitfield3
reviewed
Sep 18, 2025
erika-wallace
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
erika-wallace
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
erika-wallace
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
erika-wallace
temporarily deployed
to
AcceptanceTests
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Work Item
This PR converts the
drainscommand and its associated tests to ESM.Testing
yarn install && yarn build./bin/run drains -a <app>, confirm that drains are listed./bin/run drains:add syslog://logs.example.com -a <app>, confirm success message./bin/run drains:remove syslog://logs.example.com -a <app>, confirm success message