feat: update misc CLI output with semantic colors and remove strip-ansi#3499
Merged
Conversation
84aeafc to
f2ed1ee
Compare
michaelmalave
requested changes
Jan 28, 2026
Contributor
michaelmalave
left a comment
There was a problem hiding this comment.
This looks good and works as expected. Only one dependency comment.
Enhance CLI output by adding semantic colors to currently uncolorized text:
- spaces/index.ts: Add state-based colors (success/warning/failure) to space states, use color.team() for team references
- apps/rename.ts: Add color.info() to URLs and color.name() to git remote names
- domains/index.ts: Add color.info() to heroku domain hostname
- config/index.ts: Add color.label() to config var keys in shell output
- releases/info.ts: Add color.label() to config var keys in shell output
- clients/{create,info,rotate}.ts: Add color.label() to OAuth env var names and color.info() to values
This improves readability and consistency by colorizing entity references and important information that previously lacked color.
Systematically fix color usage issues identified in COLOR_AUDIT_REPORT.md: HIGH PRIORITY FIXES: - Replace color.cyan.bold() with color.code() for inline command references - Replace color.cyan() with color.name() for resource IDs (backup IDs, versions) - Replace color.cyan/green() with color.info() for URLs - Replace color.green/yellow() with color.success/warning() for dyno states - Replace color.green() with color.name() for config var keys - Replace color.green() with color.datastore() for database names - Replace color.red/yellow/gray() with color.failure/warning/inactive() for release statuses - Replace color.green/cyan/yellow() with color.label/info() for dyno types/sizes FILES MODIFIED: - pg/backups/index.ts: Command examples, backup IDs, database names - pg/backups/info.ts: Backup IDs, command examples - pg/backups/schedules.ts: Schedule names, command examples - pg/info.ts: Config var keys - ps/index.ts: URLs, dyno states, dyno types/sizes - apps/create.ts: URLs - apps/info.ts: URLs - config/set.ts: Config var keys - releases/info.ts: Release statuses, version numbers - spaces/index.ts: Space states with state-based colors This addresses all high-priority issues from the audit report, improving color consistency and semantic meaning throughout the CLI.
This commit addresses medium-priority color inconsistencies identified in the color audit, converting remaining cyan/green/yellow colors to semantic color functions: - Removed role colors (metadata doesn't need emphasis) - Fixed email colors to use color.user() - Fixed token/authorization colors to use color.name() - Fixed region colors to use color.info() - Fixed buildpack colors to use color.info() - Fixed error message colors in config:set - Fixed dyno type colors to use color.label() - Fixed info-level error colors to use color.info() - Added conditional status colors (pending → warning, active → success)
Addresses final high-priority color audit issue: - Change command example from color.cyan.bold() to color.code() - Change backup schedule name from color.green() to color.name()
fcd0d99 to
dcc6eaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances CLI output by adding semantic colors to currently uncolorized text in various commands and also fixing misc color use instances. It also replaces
strip-ansiwithansis.stripand removesstrip-ansias a dependency.Type of Change
Feature Additions (minor semver update)
Testing
Notes:
Changes only affect color styling - no behavioral changes. Visual verification recommended.
Steps:
npm run build✅heroku spacesheroku apps:rename --app test newnameheroku domains --app testheroku clients:create "Test" https://example.comRelated Issues
https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002T2hvTYAR/view