-
Notifications
You must be signed in to change notification settings - Fork 234
build: remove monorepo and lerna #3508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
eablack
wants to merge
8
commits into
v11.0.0
Choose a base branch
from
eb/remove-monorepo-and-lerna
base: v11.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+11,868
−18,406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package-lock.json was out of sync with package.json after removing the monorepo structure, causing npm ci to fail in CI. Regenerated the lock file to resolve dependency mismatches.
Update test and config file paths that were still referencing the old monorepo structure (packages/cli).
After switching from /lib to /dist in commit 1fad4d5, the oclif.config.mjs wasn't updated to point to the new directory. This caused commands to not be discovered. Also set OCLIF_TEST_ROOT environment variable in test init to help @oclif/test find the CLI root after monorepo removal.
The apps:create command creates actual git remotes when running in a git repository. In tests, this was creating a 'heroku' remote pointing to 'foobar' which then interfered with other tests that check for app names from git remotes. Added cleanup in afterEach to remove any heroku remotes created during the tests.
After removing the monorepo structure, the example Procfile that local command tests depended on was deleted. Created a test fixture at test/fixtures/local/Procfile with the same content. Updated tests that verify default Procfile loading to change directory to the fixtures location before running, ensuring they can find the default Procfile without explicitly specifying the path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP