Conversation
Moved the "Running <command> on <app>" status message to display after the dyno is successfully created, rather than before the API call. This ensures the spinner doesn't interfere with inquirer's readline interface when a 2FA prompt is displayed during the dyno creation POST request. Previously, the spinner would start before the API call, and if 2FA was required, inquirer would try to prompt while the spinner was still active, causing the prompt to be reprinted on every keystroke.
eablack
changed the title
k80bowman
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the 2FA prompt repeats itself on every keystroke when running
heroku runcommands that require two-factor authentication.The root cause was that the "Running on " spinner was started before the dyno creation API call. When the API returned a 403 requiring 2FA, inquirer would attempt to prompt for the code while the oclif action spinner was still running. The spinner's cursor manipulation interfered with inquirer's readline interface, causing the prompt text to be reprinted with each keystroke.
This fix moves the status message to display after the dyno is successfully created, ensuring any 2FA prompts appear without active spinner interference.
Type of Change
Patch Updates (patch semver update)
Testing
Notes:
This issue only occurs with the
heroku runcommand when 2FA is required.Steps:
heroku run bashon an app requiring 2FARelated Issues
https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002VUyU7YAL/view