Conversation
…nsive telemetry debug logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a regression where telemetry was not being sent for version/help commands, and adds comprehensive debug logging throughout the telemetry system to improve observability.
Key Changes:
version,--version,-v)DISABLE_TELEMETRY=true,Windows platform requires ENABLE_WINDOWS_TELEMETRY=true)isTelemetryEnabled()once instead of twiceProblem:
When the telemetry architecture was refactored in commit c13074d, the
beforeExithandler was removed to avoid duplicate sends. This caused version/help commands to stop sending telemetry entirely because they don't trigger the postrun hook (oclif handles them specially).Solution:
telemetrySentflag toTelemetryGlobalinterfaceType of Change
Patch Updates (patch semver update)
Testing
Notes:
Set
DEBUG=heroku:analyticsto see telemetry debug output.Steps:
DEBUG=heroku:analytics heroku version- should see telemetry sent via beforeExitDEBUG=heroku:analytics heroku apps:info --app myapp- should see telemetry sent via postrun (no duplicate from beforeExit)DEBUG=heroku:analytics DISABLE_TELEMETRY=true heroku version- should see clear "disabled" messages with reasonsENABLE_WINDOWS_TELEMETRY=true: Should see appropriate disabled messageScreenshots (if applicable)
N/A - Debug logging output only
Related Issues
https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002XtZcuYAF/view