Skip to content

refactor: rename lib and script files to kebab-case#3663

Merged
eablack merged 3 commits intomainfrom
eb/rename-lib-files-kebab-case
Apr 14, 2026
Merged

refactor: rename lib and script files to kebab-case#3663
eablack merged 3 commits intomainfrom
eb/rename-lib-files-kebab-case

Conversation

@eablack
Copy link
Copy Markdown
Contributor

@eablack eablack commented Apr 14, 2026

Summary

Rename 24 files from camelCase/snake_case to kebab-case for consistency with coding standards. This PR contains only file renames and updated import paths - no functional changes.

Files Renamed:

  • Lib files (22):
    • confirmCommand.tsconfirm-command.ts
    • teamUtils.tsteam-utils.ts
    • Addons: addons_wait.ts, create_addon.ts, destroy_addon.ts → kebab-case
    • Certs: certificate_details.ts, display_table.ts, format_date.ts, get_cert_and_key.ts → kebab-case
    • Container: docker_helper.tsdocker-helper.ts
    • Data: baseCommand.ts, createPool.ts, credentialUtils.ts, displayQuota.ts, parseProvisionOpts.ts, poolConfig.ts → kebab-case
    • PG: push_pull.tspush-pull.ts
    • Types: app_errors.ts, app_process_tier.ts → kebab-case
    • Utils: keyValueParser.ts, tableUtils.ts → kebab-case
  • Script files (2):
    • getHerokuS3Bucket.jsget-heroku-s3-bucket.js
    • isStableRelease.jsis-stable-release.js

Changes:

  • 121 files changed (24 renames + 97 import path updates)
  • 128 insertions(+), 128 deletions(-)

Type of Change

  • refactor: Refactoring existing code without changing behavior

Testing

Notes:

  • All renames were done using git mv to preserve history
  • All import paths were systematically updated across the codebase
  • TypeScript compilation passes
  • Unit tests pass

Steps:

  1. npm run build - confirms all imports resolve correctly
  2. npm run test:ci:unit - confirms all tests pass
  3. Verify CI checks pass

Related Issues

Part of the work done in #3661

Rename 24 files from camelCase/snake_case to kebab-case for consistency:
- confirmCommand.ts → confirm-command.ts
- teamUtils.ts → team-utils.ts
- All addons lib files (addons_wait, create_addon, destroy_addon)
- All certs lib files (certificate_details, display_table, format_date, get_cert_and_key)
- All data lib files (baseCommand, createPool, credentialUtils, displayQuota, parseProvisionOpts, poolConfig)
- All container lib files (docker_helper)
- All pg lib files (push_pull)
- All types lib files (app_errors, app_process_tier)
- All utils lib files (keyValueParser, tableUtils)
- Script utilities (getHerokuS3Bucket, isStableRelease)

Updated 100 files with corrected import paths. No functional changes.
@eablack eablack requested a review from a team as a code owner April 14, 2026 18:48
@eablack eablack temporarily deployed to AcceptanceTests April 14, 2026 18:48 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests April 14, 2026 18:48 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests April 14, 2026 18:48 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests April 14, 2026 18:48 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests April 14, 2026 19:47 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests April 14, 2026 19:47 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests April 14, 2026 19:47 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests April 14, 2026 19:47 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

@erika-wallace erika-wallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Fixes linting errors by updating import paths to include src/ directory after file rename from sni_endpoint to sni-endpoint
@eablack eablack temporarily deployed to AcceptanceTests April 14, 2026 20:03 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests April 14, 2026 20:03 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests April 14, 2026 20:03 — with GitHub Actions Inactive
@eablack eablack temporarily deployed to AcceptanceTests April 14, 2026 20:03 — with GitHub Actions Inactive
@eablack eablack merged commit c6a101f into main Apr 14, 2026
17 checks passed
@eablack eablack deleted the eb/rename-lib-files-kebab-case branch April 14, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants