fix: updates @heroku-cli/command to address 2FA token prompting bug#3690
Merged
Conversation
k80bowman
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
@heroku-cli/commandto v12.3.3, which contains a fix to how we're prompting. Prior to our use of theinquirerpackage, we were using OCLIF'spromptfunction; this function wrote tostderr.inquirer, by default, writes tostdout. This caused issues for some users, as it pollutedstdoutwith information intended forstderr.This PR also updates Typescript to version
5.8.3. This was necessary to support type definitions exported from@heroku-cli/command, derived from type definitions provided by theinquirerpackage.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Related Issues
GUS work item: W-22383481