deps: bump @oclif/plugin-plugins to resolve picomatch and brace-expansion advisories#3694
Merged
Merged
Conversation
Pulls in npm@11.x via @oclif/plugin-plugins, which transitively upgrades the bundled minimatch and node-gyp/tinyglobby chain so brace-expansion resolves to 5.0.5 and picomatch resolves to 4.0.4. - Resolves picomatch ReDoS via extglob (GHSA-c2c7-rcm5-vvqj, HIGH) - Resolves picomatch POSIX-class injection (GHSA-3v7f-55p6-f55p) - Resolves brace-expansion zero-step DoS (GHSA-f886-m6hf-6m8v) Closes Dependabot alerts: #271, #272, #279
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@oclif/plugin-pluginsfrom^5.4.58to^5.4.64to clear three open Dependabot advisories that share a common root cause: the previously-resolved@oclif/plugin-plugins@5.4.58bundlesnpm@10.9.6, whosenode-gyp/tinyglobbychain pinnedpicomatch@4.0.3and whose bundledminimatch@9.0.9pinnedbrace-expansion@2.0.2. The new version pullsnpm@11.14.0, which transitively resolves all three packages to patched versions.After this change:
picomatch→4.0.4(was4.0.3)brace-expansion→5.0.5on the affected chain (was2.0.2)No
overridesare introduced — this is a same-major patch bump of a direct dependency.Advisories closed
Risk notes
npmjumps10.9.6 → 11.14.0; bundlednode-gypjumps11.5.0 → 12.3.0. These are higher-major bumps, but they are bundled inside@oclif/plugin-pluginsand only invoked when the CLI installs/updates user plugins.npm@11requires Node.js^20.17.0 || >=22.9.0. Currentengines.nodealready satisfies this.picomatch/brace-expansioninstances in the tree were already on patched versions; this PR only changes the one vulnerable subtree.Test plan
npm installcleannpm ls picomatch --allshows only4.0.4and2.3.2npm ls brace-expansion --allshows no2.0.2npm run buildsucceedsnpm run lintsucceeds (0 errors)npm testpasses (1955 passing)heroku plugins:install <plugin>,heroku plugins,heroku plugins:uninstall <plugin>