Skip to content

feat: remove cached netrc account on logout#3710

Merged
k80bowman merged 4 commits into
feat/credential-mgr-integrationfrom
k80/remove-netrc-logout
May 14, 2026
Merged

feat: remove cached netrc account on logout#3710
k80bowman merged 4 commits into
feat/credential-mgr-integrationfrom
k80/remove-netrc-logout

Conversation

@k80bowman
Copy link
Copy Markdown
Contributor

Summary

Adds functionality to the heroku logout command to remove cached .netrc credentials when a user logs out.

Type of Change

Breaking Changes (major semver update)

  • Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

  • feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

  • fix: Bug fix
  • deps: Dependency upgrade
  • revert: Revert a previous commit
  • chore: Change that does not affect production code
  • refactor: Refactoring existing code without changing behavior
  • test: Add/update/remove tests

Testing

Notes:

Steps:

  1. Check out this branch and run npm i && npm run build
  2. Run HEROKU_NETRC_WRITE=true ./bin/run login to log in to a Heroku account and save the credentials in a .netrc account.
  3. Run HEROKU_NETRC_WRITE=true ./bin/run accounts:add account1 to create a cache file for your Heroku account.
  4. Run HEROKU_NETRC_WRITE=true ./bin/run accounts. You should see "account1" listed.
  5. Run ./bin/run logout to log out of your Heroku account.
  6. Run HEROKU_NETRC_WRITE=true ./bin/run accounts. You should no longer see "account1" listed.

Screenshots (if applicable)

Related Issues

GUS work item: W-22452701

@k80bowman k80bowman requested a review from a team as a code owner May 14, 2026 14:49
@k80bowman k80bowman temporarily deployed to AcceptanceTests May 14, 2026 14:55 — with GitHub Actions Inactive
@k80bowman k80bowman temporarily deployed to AcceptanceTests May 14, 2026 14:55 — with GitHub Actions Inactive
@k80bowman k80bowman temporarily deployed to AcceptanceTests May 14, 2026 14:55 — with GitHub Actions Inactive
@k80bowman k80bowman temporarily deployed to AcceptanceTests May 14, 2026 14:55 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

@tlowrimore-heroku tlowrimore-heroku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k80bowman k80bowman merged commit b07137b into feat/credential-mgr-integration May 14, 2026
17 checks passed
@k80bowman k80bowman deleted the k80/remove-netrc-logout branch May 14, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants