fix: 'run:inside' args ordering (W-22693654)#3727
Merged
Merged
Conversation
michaelmalave
added a commit
that referenced
this pull request
May 29, 2026
* fix: add missing warning to 'data:pg:migrate' (W-22544849) (#3716) fix: add missing warning to 'data:pg:migrate' * chore: add CLAUDE.md and Copilot instructions pointing to AGENTS.md (#3724) Both Claude Code and GitHub Copilot Code Review look for tool-specific instruction files (CLAUDE.md and .github/copilot-instructions.md respectively). Point both at the canonical AGENTS.md so we don't have to maintain duplicate guidelines per tool. * fix: pass empty string to rl.write in repl finally block (W-22295448) (#3721) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: 'run:inside' args ordering (W-22693654) (#3727) fix: 'run:inside' args ordering * Centralize PG upgrade SDK calls in src/lib/pg/sdk-adapter.ts by adding shared runUpgrade/prepareUpgrade/dryRunUpgrade helpers and refactor the corresponding upgrade commands to use them instead of repeating inline SDK method casting. * Tighten ps SDK adapter typings by replacing broad unknown casts with targeted @ts-expect-error annotations and explicit function types to document current heroku-types gaps while keeping calls type-safe. * Refactor ps commands to remove the dedicated SDK adapter, inline SDK interactions in ps:index/ps:scale, and update lockfile and unit tests to match the simplified implementation and typing behavior * Refactor ps:index to unify extended/non-extended dyno fetching and simplify quota parameter handling, while tightening ps:scale type-safe shield size formatting to avoid unsafe fallback conversions --------- Co-authored-by: Santiago Bosio <santiago.bosio@gmail.com> Co-authored-by: Eric <eblack@salesforce.com> Co-authored-by: Johnny Winn <88165065+heroku-johnny@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In PR #3633 we provided a fix for the issue reported on Github issue #3631. The fix included reordering the static class member
argsto ensuredyno_namewas the first positional argument.In PR #3667 we inadvertently reverted that ordering because the
perfectionist/sort-objectsrule was applied. That linter rule shouldn't be ever applied to the args static class member, because positioning is relevant for the commands to work correctly.Type of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
There's a Fir test app available in our Fir Test space named
test-cli-run-insideor you can use your own test app.Steps:
npm install && npm run build.heroku run:inside web-c8c859bf9-2rk6q bash -a test-cli-run-inside, you'll observe the errorbash is either not "up" or doesn't exist.being raised../bin/run run:inside web-c8c859bf9-2rk6q bash -a test-cli-run-inside, the dyno connection should be correctly established and a bash session opened. Useexitto quit the session and close the connection to the dyno.Screenshots (if applicable)
Related Issues
GitHub issue: #3726
GUS work item: W-22693654