Skip to content

feat: migrate adapters to sdk#3735

Merged
michaelmalave merged 5 commits into
feat/heroku-sdk-integrationfrom
mm/feat/migrate-out-adapters-to-sdk
Jun 1, 2026
Merged

feat: migrate adapters to sdk#3735
michaelmalave merged 5 commits into
feat/heroku-sdk-integrationfrom
mm/feat/migrate-out-adapters-to-sdk

Conversation

@michaelmalave
Copy link
Copy Markdown
Contributor

@michaelmalave michaelmalave commented May 29, 2026

Summary

This PR continues SDK integration cleanup on top of feat/heroku-sdk-integration by simplifying PG, addons, and pipelines command internals while preserving behavior. Scope is focused on removing obsolete PG adapter indirection, tightening direct SDK call paths, and updating affected tests/mocks.

  • Remove src/lib/pg/sdk-adapter.ts and migrate remaining PG command usage to direct SDK calls
  • Refactor PG backups, credentials, and upgrade commands to align with the direct-call SDK pattern
  • Refactor addons/pipelines command flows and related disambiguation/log-display logic for SDK consistency
  • Update shared SDK mocks and unit tests across addons, PG, and pipelines command suites to match new call patterns

Type of Change

  • fix: Bug fix or issue (patch semvar update)
  • feat: Introduces a new feature to the codebase (minor semvar update)
  • perf: Performance improvement
  • docs: Documentation only changes
  • tests: Adding missing tests or correcting existing tests
  • chore: Code cleanup tasks, dependency updates, or other changes

Verification

Build and Testing Pass

npm install && npm run build
npm run test

Additional Context

  • Breaking: none expected
  • Risk: low to medium; internal command-path refactors with broad test updates
  • Merge target: feat/heroku-sdk-integration

Related Issue

GUS work item: W-22782530

…b/pg/sdk-adapter.ts abstraction and call SDK APIs directly in backups, credentials, and upgrade command handlers
…grade tests to align with direct SDK call patterns and remove redundant test mocking/setup codem-app
…ion and log display paths) and update pipeline/addon test fixtures to match the new call patterns and response handling
…DK request/response handling, update their unit tests for the new behavior
…y wiring to keep SDK integration references consistent
Copy link
Copy Markdown
Contributor

@tlowrimore-heroku tlowrimore-heroku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michaelmalave michaelmalave merged commit 9be770f into feat/heroku-sdk-integration Jun 1, 2026
5 of 18 checks passed
@michaelmalave michaelmalave deleted the mm/feat/migrate-out-adapters-to-sdk branch June 1, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants