Additional Steps for Windows #50
Conversation
edmorley
left a comment
edmorley
left a comment
There was a problem hiding this comment.
Hi! Thank you for opening a PR.
This repository goes alongside the "Getting Started on Heroku with Go" guide here:
https://devcenter.heroku.com/articles/getting-started-with-go
In that guide, the "running locally" section says to go install -v . prior to running heroku local, which I believe then makes the current Procfile work as is.
As such, I think the real fix here is to update the comment being run to build/install the project, rather than to suggest the user change what is in the Procfile. As-is, I think the current advice in the README here is not only broken on Windows, but on Linux too, since it says to save the contents of the go build into a bin directory, which differs from the path in Procfile.
However, rather than fix the instructions in README, I think it might be best to remove them entirely, and instead link out to the full guide on Dev Center, since it saves having to keep both in sync. Linking out to Dev Center is also what the READMEs for many of the other language's getting started guides do already, eg:
In order to: 1. Make the README consistent with those for our other getting started guides (eg https://github.com/heroku/python-getting-started/blob/main/README.md) 2. Resolve the issues raised in #50 (the currently running locally steps in the README are incomplete, and users are better off following the full guide) Closes #50. Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
In order to: 1. Make the README consistent with those for our other getting started guides (eg https://github.com/heroku/python-getting-started/blob/main/README.md) 2. Resolve the issues raised in #50 (the currently running locally steps in the README are incomplete, and users are better off following the full guide) Closes #50. Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
2 participants
Please consider this pull request with details from the solved issue to run in Windows. I faced the problems before checking the issues and lost some time. Only a small change in readme.