Fixing a bug that caused URL paths to be excluded #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an issue with how urljoin worked in that if a URL contained a path in the first parameter it would be excluded when the join took place. Our test coverage didn't check for this kind of condition initially.
mble-sfdc
approved these changes
Jun 6, 2025
binarycleric
added a commit
that referenced
this pull request
Jun 6, 2025
This is an issue with how urljoin worked in that if a URL contained a path in the first parameter it would be excluded when the join took place. Our test coverage didn't check for this kind of condition initially.
binarycleric
added a commit
that referenced
this pull request
Jun 6, 2025
This is an issue with how urljoin worked in that if a URL contained a path in the first parameter it would be excluded when the join took place. Our test coverage didn't check for this kind of condition initially.
binarycleric
added a commit
that referenced
this pull request
Jun 6, 2025
This is an issue with how urljoin worked in that if a URL contained a path in the first parameter it would be excluded when the join took place. Our test coverage didn't check for this kind of condition initially.
This was referenced Jun 9, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
This is an issue with how urljoin worked in that if a URL contained a path in the first parameter it would be excluded when the join took place. Our test coverage didn't check for this kind of condition initially.
Fixes #W-18725788
What Changed
Using
yarlto handle URI parsing.Checklist
pdoc3to generate the documentationTesting
# Example pytest python examples/your_example.py